← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Fix layer color swatches in Linux

 

one option is to not have the color indicator as a control at all,
have it as only an indicator and if you double click on the layer
widget row (or right click -> properties) you get another dialog that
then has a real color well control. This will remove the hacky
behaviour on a button and also make it so that later on (when its
supported) you can change the layer name and type. while reducing the
area of single misclick. I have done a very quick gimp mockup where
the color is moved right to the edge, but it is currently missing
visibility and active layer indicators, visibility should probably be
done through an eye rather than checkbox, As the checkbox can also
fool people into thinking its disabling the layer not just changing
its visibility

On 23 February 2017 at 07:18, John Beard <john.j.beard@xxxxxxxxx> wrote:
> Hi Wayne,
>
> I rebased the patches onto the COLOR4D work.
>
> I've also added a further refactor than generalises the row indicator
> icons, which removes a bit more logic from the layer widgets, and can
> be reused as a generic switchable icon for other purposes if needed (I
> had an Inkscape-style "eye" for the visibility checkbox in mind, but
> it's not limited to two states, or to just the layer widget).
>
> I've put both the COLOR_SWATCH and INDICATOR_ICONS in common/widgets.
>
> There's a lot more scope for tidying this widget, and other UI ideas
> abound. This should help a little to tidying up, and at least makes it
> usable and consistent across platforms for v5.
>
> Cheers,
>
> John
>
> On Tue, Feb 21, 2017 at 11:05 PM, John Beard <john.j.beard@xxxxxxxxx> wrote:
>> On Tue, Feb 21, 2017 at 10:41 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>> I forgot to mention that this will likely clash with the COLOR4D work
>>> that is already in progress so we will have to coordinate the changes.
>>
>> Happy to rebase as needed.
>>
>>> On 2/21/2017 9:35 AM, Wayne Stambaugh wrote:
>>>> My only issue with this change is that the tooltip letting the user know
>>>> that a left button double click or a middle button click would allow
>>>> them to change the color is gone.
>>
>> The tooltip is still there for me (Linux). I specifically checked it,
>> as I think it's a useful thing, since there's no other affordance on
>> the swatches to tell you what to do. I hope it's not platform specfic
>> as to whether the swatch wxStaticBitmap or the COLOR_SWATCH panel
>> provide the tooltip.
>>
>> Cheers,
>>
>> John
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Attachment: Screen Shot 2017-02-23 at 07.29.16.png
Description: PNG image


Follow ups

References