← Back to team overview

kicad-developers team mailing list archive

Re: PATCH: fix for bug 1659027

 

On Wed, Feb 22, 2017 at 11:13 PM, Nick Østergaard <oe.nick@xxxxxxxxx> wrote:
> 2017-02-22 9:10 GMT+01:00 Cirilo Bernardo <cirilo.bernardo@xxxxxxxxx>:
>> I have attached a patch to the bug report:
>>
>> https://bugs.launchpad.net/kicad/+bug/1659027/comments/14
>>
>> I have tested on Linux and Windows but more testing/comments
>> appreciated.
>>
>> Bugs fixed:
>> 1. Rejection of 3D files with upper-case extensions in Windows
>> 2. non-ASCII path bug in fileType() function of 3D plugin
>> 3. non-ASCII path bugs in KiCad's 3D cache object
>>
>> Notes:
>>
>> * non-ASCII path bugs are likely present in the other
>> 3D plugins (vrml, x3d, IDF) so I need to have a look at the
>> code for those and fix the bugs.
>>
>> * there is a fundamental non-ASCII path bug in OpenCascade
>> and by extension OCE: on Windows OpenCascade/OCE do
>> not provide a mechanism for opening files via Windows'
>> _wfopen() function so only files with a pure ASCII path may
>> be processed. Some posts on the web suggest that this bug
>> has been fixed in the latest version of OpenCascade but I
>> haven't had time to verify this. For the moment, in Windows
>> only, we cannot use files which have any non-ASCII characters
>> in the absolute path. Linux is not affected and I have no idea
>> about OSX.
>
> For easier verification, do you have the reference to the place where
> it says this was fixed on OCC?
>

In the OpenCascade 6.8 Release Notes it is claimed that the
Data Exchange modules (XCAF, but presumably OCAF as well)
UTF8 for filenames is supported. If that is true then the bug may
disappear once the fixed OpenCascade/OCE is installed and with
no work required on KiCad's part.

https://www.opencascade.com/sites/default/files/documents/Release_Notes_6.8.0.pdf

- Cirilo

>>
>> - Cirilo
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp


References