kicad-developers team mailing list archive

Thread
Date

Re: [PATCH] Fix MacOS coroutine segfault

To: <kicad-developers@xxxxxxxxxxxxxxxxxxx>
From: Maciej Sumiński <maciej.suminski@xxxxxxx>
Date: Thu, 23 Feb 2017 11:36:02 +0100
Authentication-results: spf=pass (sender IP is 188.184.36.46) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
In-reply-to: <20170223012359.GA19612@beast.local>
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

Hi Chris,

Would you give more details about the problem? Boost version, backtrace?

Regards,
Orson

On 02/23/2017 02:23 AM, Chris Pavlina wrote:
> Hi,
> 
> pcbnew is segfaulting on launch on my MacOS Sierra build, due to a null
> dereference in the coroutine code:
> 
> coroutine.h
> 408    static CONTEXT_T callerStub( CONTEXT_T caller, INVOCATION_ARGS* aArgsPtr )
> 409    {
> 410        const auto& args = *aArgsPtr;
> 411        auto* cor = args.destination;
> 
> aArgsPtr is null and I don't understand WHY. However, I was able to make
> things appear to work by short-circuiting this function if the argument
> is null.
> 
> Patch attached. It Works For Me™, but I'd like someone who knows the
> coroutine code to look and make sure I haven't made a mess of things.
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Attachment: signature.asc
Description: OpenPGP digital signature

Follow ups

Re: [PATCH] Fix MacOS coroutine segfault
From: Chris Pavlina, 2017-02-23

References

[PATCH] Fix MacOS coroutine segfault
From: Chris Pavlina, 2017-02-23