← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Fix MacOS coroutine segfault

 

just fyi

https://bugs.launchpad.net/kicad/+bug/1658249

On 24 February 2017 at 00:38, Chris Pavlina <pavlina.chris@xxxxxxxxx> wrote:
> Backtrace attached. Boost is 1.63.0.
>
> On Thu, Feb 23, 2017 at 11:36:02AM +0100, Maciej Sumiński wrote:
>> Hi Chris,
>>
>> Would you give more details about the problem? Boost version, backtrace?
>>
>> Regards,
>> Orson
>>
>> On 02/23/2017 02:23 AM, Chris Pavlina wrote:
>> > Hi,
>> >
>> > pcbnew is segfaulting on launch on my MacOS Sierra build, due to a null
>> > dereference in the coroutine code:
>> >
>> > coroutine.h
>> > 408    static CONTEXT_T callerStub( CONTEXT_T caller, INVOCATION_ARGS* aArgsPtr )
>> > 409    {
>> > 410        const auto& args = *aArgsPtr;
>> > 411        auto* cor = args.destination;
>> >
>> > aArgsPtr is null and I don't understand WHY. However, I was able to make
>> > things appear to work by short-circuiting this function if the argument
>> > is null.
>> >
>> > Patch attached. It Works For Me™, but I'd like someone who knows the
>> > coroutine code to look and make sure I haven't made a mess of things.
>> >
>> >
>> >
>> > _______________________________________________
>> > Mailing list: https://launchpad.net/~kicad-developers
>> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> > More help   : https://help.launchpad.net/ListHelp
>> >
>>
>>
>
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>


Follow ups

References