kicad-developers team mailing list archive

[John Beard <john.j.beard@xxxxxxxxx>]

Hi,

The COMMON_TOOLS GAL tool wasn't registered in modedit, so the grid
setting didn't work.

Here's a patch. This fixes lp:1667264, possibly the tersest bug report
ever, with a grand total of 6 words and a colon, plus the copy-paste
version info.

Any bug reporters out there, pretty please use your words when
reporting bugs - in this case mentioning that it was GAL only would
have been a good pointer for a start!

Cheers,

John

From 8911c539669832d5b4e261acbbe48ca9ffa25b98 Mon Sep 17 00:00:00 2001
From: John Beard <john.j.beard@xxxxxxxxx>
Date: Thu, 23 Feb 2017 22:02:18 +0800
Subject: [PATCH] Register COMMON_TOOLS in modedit

Without this, no actions from that tool will work, which includes things
like settings the grid size.

Fixes: lp:1667264
* https://bugs.launchpad.net/kicad/+bug/1667264
---
 pcbnew/moduleframe.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/pcbnew/moduleframe.cpp b/pcbnew/moduleframe.cpp
index 1e6e7daed..99c45e249 100644
--- a/pcbnew/moduleframe.cpp
+++ b/pcbnew/moduleframe.cpp
@@ -58,7 +58,9 @@
 #include <invoke_pcb_dialog.h>
 
 #include <tool/tool_manager.h>
+#include <tool/common_tools.h>
 #include <tool/tool_dispatcher.h>
+
 #include "tools/selection_tool.h"
 #include "tools/zoom_tool.h"
 #include "tools/edit_tool.h"
@@ -950,6 +952,7 @@ void FOOTPRINT_EDIT_FRAME::setupTools()
 
     drawPanel->SetEventDispatcher( m_toolDispatcher );
 
+    m_toolManager->RegisterTool( new COMMON_TOOLS );
     m_toolManager->RegisterTool( new SELECTION_TOOL );
     m_toolManager->RegisterTool( new ZOOM_TOOL );
     m_toolManager->RegisterTool( new EDIT_TOOL );
-- 
2.11.0