kicad-developers team mailing list archive

[Mário Luzeiro <mrluzeiro@xxxxx>]

I am *sorry*

Mario

________________________________________
From: Chris Pavlina [pavlina.chris@xxxxxxxxx]
Sent: 23 February 2017 22:06
To: Mário Luzeiro
Cc: Simon Richter; KiCad Developers
Subject: Re: [Kicad-developers] Optimization flags in 3d-viewer

On Thu, Feb 23, 2017 at 03:48:39PM +0000, Mário Luzeiro wrote:
> Yes I added it, because for 3D we need *speeeeeed* :P

Things like this are speed holes. https://youtu.be/whnms4CLJys?t=42

*Please* do not add speed holes. If your code is not faster, add
optimizations you understand, and remove them after testing if they do
not show a marked improvement. This just makes the build messy...

>
> What kind of warnings it is causing? O_o
>
> Mario
> ________________________________________
> From: Kicad-developers [kicad-developers-bounces+mrluzeiro=ua.pt@xxxxxxxxxxxxxxxxxxx] on behalf of Simon Richter [Simon.Richter@xxxxxxxxxx]
> Sent: 23 February 2017 15:25
> To: KiCad Developers
> Subject: [Kicad-developers] Optimization flags in 3d-viewer
>
> Hi,
>
> in 3d-viewer/CMakeLists.txt we have
>
> set( CMAKE_C_FLAGS_RELEASE   "-O3" )
> set( CMAKE_CXX_FLAGS_RELEASE "-O3" )
>
> Is that intentional?
>
>  - it seems to be unused in the Make based builds
>  - it overwrites any existing flags in these variables
>  - it causes warnings on MSVC
>
>    Simon
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp