kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #28277
Re: Change behaviour of selectCopper and selectNet feature
-
To:
<kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
From:
Maciej Sumiński <maciej.suminski@xxxxxxx>
-
Date:
Mon, 27 Feb 2017 18:13:21 +0100
-
Authentication-results:
spf=pass (sender IP is 188.184.36.48) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
In-reply-to:
<f94ccdf5-e668-3183-9487-8656c84308c6@gmx.at>
-
Spamdiagnosticmetadata:
NSPM
-
Spamdiagnosticoutput:
1:99
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0
Hi Thomas,
I see your point, but before we merge your patch, we need to address the
other problem first. I would like to see a bug report, but I guess this
behavior is hard to trigger without applying your patch first.
BTW. are the rendering glitches visible in the linked video occurring in
KiCad as well?
Regards,
Orson
On 02/24/2017 12:28 AM, Thomas Pointhuber wrote:
> Hy,
>
> I think the "select Copper" and "select Net" feature should also select
> zones, and not only track's and via's.
>
> When thinking about a user which doesn't know the behavior of the
> "select Copper" feature, it should be the expected assumption that this
> feature is really selecting the interconnected copper area, and not only
> interconnected track's and via's.
>
> This patch adds this behavior.
>
> Unfortunately the patch is not working in all cases at the moment, due
> to a regression which triggers an assert, when someone want's to "select
> Copper" on a zone which is not filled but the internal state say's
> other. It seems IsFilled return's true in some cases where the zone is
> actually not filled.
>
> I created a video which I illustrates such a case where the variable is
> not set as expected: https://owncloud.oe5tpo.com/index.php/s/YxqNpq4NxebmJGW
>
> Regards, Thomas
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Attachment:
signature.asc
Description: OpenPGP digital signature
Follow ups
References