kicad-developers team mailing list archive

["Sergey A. Borshch" <sb-sf@xxxxxxxxxxxxxxxxxxxxx>]

On 28.02.2017 10:33, Julius Schmidt wrote:
> I know about %zu, but this is wx Printf, not C99 printf. Does it also support
> %zu?
Yes, it does:
http://docs.wxwidgets.org/3.1/classwx_string.html#a9588b7f2684b9a6a924dc3746a2b2f8d
--- quote: ----
Note
This function will use a safe version of vsprintf() (usually called vsnprintf()) 
whenever available to always allocate the buffer of correct size. Unfortunately, 
this function is not available on all platforms and the dangerous vsprintf() 
will be used then which may lead to buffer overflows.
---------------
so it use C99 (vs(n))printf itself and must have %zu "from the box".

> Do we use it anywhere else?
Is it a reason to do it wrong way here?

> On Tue, 28 Feb 2017, Sergey A. Borshch wrote:
>
> > On 28.02.2017 01:54, Julius Schmidt wrote:
> > >  This patch fixes a format string assertion.
> > ...
> > >  -            txt.Printf( wxT( "%u" ), net->m_PadInNetList.size() );
> > >  +            txt.Printf( wxT( "%u" ), (unsigned)
> > >  net->m_PadInNetList.size() );
> >
> > std::vector::size() returns size_t type. Why should you typecast variable type
> > instead of fixing format specifier to be consistent with actual variable type?
> > There is %zu format specifier designed specially for size_t type since C99.

--
Regards,
  Sergey A. Borshch            mailto: sb-sf@xxxxxxxxxxxxxxx
    SB ELDI ltd. Riga, Latvia