kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Sorry John.  I was going to recommend we apply your patch as is
(assuming you didn't change the click behavior) to fix the gtk issue.
We can discuss other changes to the behavior later.  I'll try to get to
it this evening.

On 2/28/2017 12:01 PM, John Beard wrote:
> Hi,
> 
> Sorry to bump, but this patchset fixes a fairly annoying usability bug
> on Linux/GTK+.
> 
> Are there any comments about it? It seems to work OK my my development
> branch. There have been no conflicts in the last week, but I rebased
> it up to master anyway.
> 
> Cheers,
> 
> John
> 
> On Thu, Feb 23, 2017 at 8:38 AM, John Beard <john.j.beard@xxxxxxxxx> wrote:
>> Hi,
>>
>> Please use this branch instead:
>>
>> https://code.launchpad.net/~john-j-beard/kicad/+git/kicad/+ref/swatches
>>
>> The patches previously omitted the new colour picker in the rebase
>> (which is kind of important!).
>>
>> Cheers,
>>
>> John
>>
>> On Thu, Feb 23, 2017 at 2:18 AM, John Beard <john.j.beard@xxxxxxxxx> wrote:
>>> Hi Wayne,
>>>
>>> I rebased the patches onto the COLOR4D work.
>>>
>>> I've also added a further refactor than generalises the row indicator
>>> icons, which removes a bit more logic from the layer widgets, and can
>>> be reused as a generic switchable icon for other purposes if needed (I
>>> had an Inkscape-style "eye" for the visibility checkbox in mind, but
>>> it's not limited to two states, or to just the layer widget).
>>>
>>> I've put both the COLOR_SWATCH and INDICATOR_ICONS in common/widgets.
>>>
>>> There's a lot more scope for tidying this widget, and other UI ideas
>>> abound. This should help a little to tidying up, and at least makes it
>>> usable and consistent across platforms for v5.
>>>
>>> Cheers,
>>>
>>> John
>>>
>>> On Tue, Feb 21, 2017 at 11:05 PM, John Beard <john.j.beard@xxxxxxxxx> wrote:
>>>> On Tue, Feb 21, 2017 at 10:41 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>>>> I forgot to mention that this will likely clash with the COLOR4D work
>>>>> that is already in progress so we will have to coordinate the changes.
>>>>
>>>> Happy to rebase as needed.
>>>>
>>>>> On 2/21/2017 9:35 AM, Wayne Stambaugh wrote:
>>>>>> My only issue with this change is that the tooltip letting the user know
>>>>>> that a left button double click or a middle button click would allow
>>>>>> them to change the color is gone.
>>>>
>>>> The tooltip is still there for me (Linux). I specifically checked it,
>>>> as I think it's a useful thing, since there's no other affordance on
>>>> the swatches to tell you what to do. I hope it's not platform specfic
>>>> as to whether the swatch wxStaticBitmap or the COLOR_SWATCH panel
>>>> provide the tooltip.
>>>>
>>>> Cheers,
>>>>
>>>> John