kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #28438
Re: PATCH: workaround for non-ASCII filenames in 3D files in MinGW
-
To:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
From:
Wayne Stambaugh <stambaughw@xxxxxxxxx>
-
Date:
Fri, 3 Mar 2017 14:34:55 -0500
-
In-reply-to:
<CAHBNN+M2ePWi=3Oy1KSMww9dGr1JW6sLLETiM_PJfLTyW2kWyA@mail.gmail.com>
-
User-agent:
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1
Your patch has been committed. Thank you Cirilo!
On 3/2/2017 5:59 PM, Cirilo Bernardo wrote:
> The attached patch fixes load/save issues for 3D files with
> non-ascii characters in the filename. The problem is specific
> to Windows builds and does not affect any of the UNIX-like
> platforms. This patch does not fix the corresponding issues
> with OCE/OpenCascade since that specific problem must
> be fixed in the OCE code.
>
> Regarding OCE, since we build it anyway to ensure binary
> compatibility, I'm happy to maintain our own patch set to
> fix this issue. The question is whether to work on OCE0.18
> (OCCT6.9) which doesn't currently build in MinGW and would
> thus require extra work, or to work with OCE0.17 (OCCT6.8)
> which we currently use and builds with no modifications.
>
> - Cirilo
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
References