← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] eeschema: invisible pin connection

 

Is there any objection to applying this patch in its current form? Note
that all it prevents is users accidentally joining pins that are already
invisible AND non-connect.

Cheers,
Oliver

On Wed, Feb 8, 2017 at 11:05 PM, Oliver Walters <
oliver.henry.walters@xxxxxxxxx> wrote:

> Urgh, patch attached here.
>
> On Wed, Feb 8, 2017 at 11:04 PM, Oliver Walters <
> oliver.henry.walters@xxxxxxxxx> wrote:
>
>> I have amended the patch to only ignore connection of pins that are both
>> INVISIBLE and NC (Electrical Type = Not Connected). This will improve the
>> safety of the current libraries which do contain many parts with NC pins
>> set as invisible.
>>
>> It will also NOT change the behaviour of people using invisible pins for
>> one-to-many connection.
>>
>> Thoughts?
>>
>> On Tue, Feb 7, 2017 at 7:47 PM, Oliver Walters <
>> oliver.henry.walters@xxxxxxxxx> wrote:
>>
>>> Hi all,
>>>
>>> The attached patch prevents invisible pins from being connected using
>>> the wire tool in eeschema.
>>>
>>> a) If you connect a wire endpoint to the same position as a pin
>>> endpoint, they are NOT connected visually
>>> b) Wires and insivible pins are also ignored during netlist creation
>>> c) This does not affect the ability of invisible power-pins to
>>> automatically connect to global power labels
>>>
>>> Is the current behavior of connecting invisible pins to wire endpoints
>>> desired? Or is it just an aberration?
>>>
>>> If there is a very good reason that pins not visible in the schematic
>>> are able to be connected silently?
>>>
>>> before: http://i.imgur.com/3gModvW.png
>>>
>>> after: http://i.imgur.com/r8O7c3Y.png
>>>
>>> (Note the 'dangling' wire-end indication)
>>>
>>> Cheers,
>>> Oliver
>>>
>>>
>>>
>>
>

Follow ups

References