← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Measurement tool for GAL

 

Perfect, the measurement tool is already included in the master branch.
Thanks!

Cheers,
Orson

On 03/10/2017 03:07 PM, John Beard wrote:
> Hi Orson,
> 
> That patch looks fine. Sorry about the formatting/copyright header.
> You are right for the by-ref and the const.
> 
> "Measure distance" sounds fine to me.
> 
> Cheers,
> 
> John
> 
> On Fri, Mar 10, 2017 at 9:59 PM, Maciej Sumiński
> <maciej.suminski@xxxxxxx> wrote:
>> Hi John,
>>
>> All I can say is: it looks really cool! I would like to merge, but
>> before I do so, would you consider the attached fixup patch? If so, I
>> simply update the existing set of patches and merge everything.
>>
>> Changes:
>> - Changed std::vector<> to const std::vector<>& in
>> PREVIEW::SetConstantGlyphHeight()
>>
>> - One of the new files had Tom as the copyright holder and incorrect
>> date, changed to "(c) 2017 KiCad Developers"
>>
>> - Changed "Measure between two points" to "Measure distance between two
>> points". I am not a native English speaker, so I need your advice here.
>>
>> - A few code formatting fixes.
>>
>> Cheers,
>> Orson
>>
>> On 03/10/2017 12:18 PM, John Beard wrote:
>>> Hi Nick,
>>>
>>> That's because the label formatting just uses a fixed 2 DP display for
>>> mm (it uses 4 for inches, and 1 for degrees). It's not a perfect
>>> solution, but it does line up nicely when the labels are on the left
>>> of the line. Stripping trailing zeroes would make it ragged when you
>>> zoom in a bit and get "1, 1.25, 1.5, 1.75, 2".
>>>
>>> Cheers,
>>>
>>> John
>>>
>>> On Fri, Mar 10, 2017 at 4:34 PM, Nick Østergaard <oe.nick@xxxxxxxxx> wrote:
>>>> It certainly looks quite nice. I have not yet tested the patch, but I
>>>> wonder why it shall show the integer labels here with decimals behind
>>>> it when they are all zero?
>>>>
>>>> 2017-03-09 18:18 GMT+01:00 John Beard <john.j.beard@xxxxxxxxx>:
>>>>> By the way, here's a screenshot of the ruler tool:
>>>>>
>>>>> Cheers,
>>>>>
>>>>> John
>>>>>
>>>>> On Fri, Mar 10, 2017 at 1:11 AM, John Beard <john.j.beard@xxxxxxxxx> wrote:
>>>>>> Hi,
>>>>>>
>>>>>> Here's a tool I'm had on my list for a while - a ruler tool.
>>>>>>
>>>>>> This patch set introduces a new directory, for "preview items" which
>>>>>> are EDA_ITEMS that are only used for transient previews, such as
>>>>>> drawing aids and selection boxes. These are located in common, so that
>>>>>> they can (in theory) be used in any GAL canvas, not just
>>>>>> Pcbnew/Modedit.
>>>>>>
>>>>>> There are also some functions that hopefully will be useful for other
>>>>>> preview items in future in the utils file.
>>>>>>
>>>>>> There's an oustanding bug with the OpenGL GAL in that it cannot draw
>>>>>> spaces in text, so there are a couple of places where it pre-emptively
>>>>>> strips spaces that should be removed when that bug is fixed.
>>>>>> (https://bugs.launchpad.net/kicad/+bug/1668455).
>>>>>>
>>>>>> Cheers,
>>>>>>
>>>>>> John
>>>>>
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>


Attachment: signature.asc
Description: OpenPGP digital signature


References