kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #28626
Re: [PATCH] refactor BRIGHT_BOX to common
I assume you want the header in include/preview_items as well, right?
On Sat, Mar 11, 2017 at 08:54:11AM -0500, Jon Evans wrote:
> Hi John, you are right! It was late and I didn't remember about your new
> directory but it's totally the right place. Updated patch attached.
>
> Thanks,
> Jon
>
> On Sat, Mar 11, 2017 at 7:09 AM, John Beard <john.j.beard@xxxxxxxxx> wrote:
>
> > Hi Jon,
> >
> > This looks like something that could live in common/preview_items,
> > which is where I put "transient" EDA_ITEMs (i.e. constructed with
> > NOT_USED) that are theoretically useful for any GAL canvas. So far,
> > the ruler overlay, and SELECTION_AREA are living there, but I have a
> > couple more in the pipeline.
> >
> > Not critical, just a thought while the file is being moved anyway.
> >
> > Cheers,
> >
> > John
> >
> > On Sat, Mar 11, 2017 at 1:47 PM, Jon Evans <jon@xxxxxxxxxxxxx> wrote:
> > > Hi,
> > >
> > > Quick refactor to allow use of BRIGHT_BOX from GerbView
> > >
> > > Best,
> > > Jon
> > >
> > > _______________________________________________
> > > Mailing list: https://launchpad.net/~kicad-developers
> > > Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > > Unsubscribe : https://launchpad.net/~kicad-developers
> > > More help : https://help.launchpad.net/ListHelp
> > >
> >
Follow ups
References