kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #28631
Re: [PATCH] refactor BRIGHT_BOX to common
-
To:
<kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
From:
Maciej Suminski <maciej.suminski@xxxxxxx>
-
Date:
Sat, 11 Mar 2017 21:32:45 +0100
-
Authentication-results:
spf=pass (sender IP is 188.184.36.48) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
In-reply-to:
<CA+qGbCDL3Oyq7b+Hq8tsEwZBtPcmpNyj9jhw62WHnd1=NhjTmw@mail.gmail.com>
-
Spamdiagnosticmetadata:
NSPM
-
Spamdiagnosticoutput:
1:99
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1
Hi Jon,
There are new files (pcb_bright_box.*) that say I am the author, but it
would be unfair of me to take credit for someone else's work. Shall I
change it to 'KiCad Developers' or what would be your preference?
Once it is changed, I am going to merge the patches. Thank you for your
efforts.
Regards,
Orson
On 03/11/2017 09:06 PM, Jon Evans wrote:
> Oops! Yes, thanks.
>
> On Sat, Mar 11, 2017 at 12:35 PM, Chris Pavlina <pavlina.chris@xxxxxxxxx>
> wrote:
>
>> I assume you want the header in include/preview_items as well, right?
>>
>> On Sat, Mar 11, 2017 at 08:54:11AM -0500, Jon Evans wrote:
>>> Hi John, you are right! It was late and I didn't remember about your new
>>> directory but it's totally the right place. Updated patch attached.
>>>
>>> Thanks,
>>> Jon
>>>
>>> On Sat, Mar 11, 2017 at 7:09 AM, John Beard <john.j.beard@xxxxxxxxx>
>> wrote:
>>>
>>>> Hi Jon,
>>>>
>>>> This looks like something that could live in common/preview_items,
>>>> which is where I put "transient" EDA_ITEMs (i.e. constructed with
>>>> NOT_USED) that are theoretically useful for any GAL canvas. So far,
>>>> the ruler overlay, and SELECTION_AREA are living there, but I have a
>>>> couple more in the pipeline.
>>>>
>>>> Not critical, just a thought while the file is being moved anyway.
>>>>
>>>> Cheers,
>>>>
>>>> John
>>>>
>>>> On Sat, Mar 11, 2017 at 1:47 PM, Jon Evans <jon@xxxxxxxxxxxxx> wrote:
>>>>> Hi,
>>>>>
>>>>> Quick refactor to allow use of BRIGHT_BOX from GerbView
>>>>>
>>>>> Best,
>>>>> Jon
>>>>>
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>> More help : https://help.launchpad.net/ListHelp
>>>>>
>>>>
>>
>>
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Follow ups
References