← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] refactor BRIGHT_BOX to common

 

Ok, I went for 'KiCad Developers' then. Thank you!

Regards,
Orson

On 03/11/2017 09:34 PM, Jon Evans wrote:
> Hi Orson, I kept it as you as I basically just cut your code in half and
> put part in another file. But feel free to change it to me or kicad
> developers if you wish!
> 
> Thanks,
> Jon
> 
> 
> On Mar 11, 2017 15:33, "Maciej Suminski" <maciej.suminski@xxxxxxx> wrote:
> 
> Hi Jon,
> 
> There are new files (pcb_bright_box.*) that say I am the author, but it
> would be unfair of me to take credit for someone else's work. Shall I
> change it to 'KiCad Developers' or what would be your preference?
> 
> Once it is changed, I am going to merge the patches. Thank you for your
> efforts.
> 
> Regards,
> Orson
> 
> On 03/11/2017 09:06 PM, Jon Evans wrote:
>> Oops! Yes, thanks.
>>
>> On Sat, Mar 11, 2017 at 12:35 PM, Chris Pavlina <pavlina.chris@xxxxxxxxx>
>> wrote:
>>
>>> I assume you want the header in include/preview_items as well, right?
>>>
>>> On Sat, Mar 11, 2017 at 08:54:11AM -0500, Jon Evans wrote:
>>>> Hi John, you are right!  It was late and I didn't remember about your
> new
>>>> directory but it's totally the right place.  Updated patch attached.
>>>>
>>>> Thanks,
>>>> Jon
>>>>
>>>> On Sat, Mar 11, 2017 at 7:09 AM, John Beard <john.j.beard@xxxxxxxxx>
>>> wrote:
>>>>
>>>>> Hi Jon,
>>>>>
>>>>> This looks like something that could live in common/preview_items,
>>>>> which is where I put  "transient" EDA_ITEMs (i.e. constructed with
>>>>> NOT_USED) that are theoretically useful for any GAL canvas. So far,
>>>>> the ruler overlay, and SELECTION_AREA are living there, but I have a
>>>>> couple more in the pipeline.
>>>>>
>>>>> Not critical, just a thought while the file is being moved anyway.
>>>>>
>>>>> Cheers,
>>>>>
>>>>> John
>>>>>
>>>>> On Sat, Mar 11, 2017 at 1:47 PM, Jon Evans <jon@xxxxxxxxxxxxx> wrote:
>>>>>> Hi,
>>>>>>
>>>>>> Quick refactor to allow use of BRIGHT_BOX from GerbView
>>>>>>
>>>>>> Best,
>>>>>> Jon
>>>>>>
>>>>>> _______________________________________________
>>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>
>>>>>
>>>
>>>
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


References