kicad-developers team mailing list archive

[Cirilo Bernardo <cirilo.bernardo@xxxxxxxxx>]

On Mon, Mar 13, 2017 at 2:18 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
> Cirilo,
>
> I'm in the process of committing your patches and I want to be sure this
> is the correct oce patch.
>

Yes, this is the correct OCE patch; the only thing to remember is that it
is exclusively for MinGW and should not be applied to any other build.

- Cirilo

> Thanks,
>
> Wayne
>
> On 3/6/2017 4:00 PM, Cirilo Bernardo wrote:
>> The last OCE patch I sent was badly formatted; this one is correctly
>> formatted against the OCE 0.17.3 tag.
>>
>> - Cirilo
>>
>> On Sun, Mar 5, 2017 at 1:59 PM, Cirilo Bernardo
>> <cirilo.bernardo@xxxxxxxxx> wrote:
>>> This patch is not really part of kicad, but it hacks OCE0.17.3
>>> to provide UTF8 filename support under MinGW.
>>>
>>> I say it's a hack because it breaks all builds except under
>>> MinGW so it should not be applied except to the MinGW
>>> build.
>>>
>>> I used the latest in the 0.17 series of OCE and did not test
>>> against the earlier version (0.17.2).  OCE 0.18 does not build
>>> cleanly under Windows yet but when we get to that point
>>> I'll update the hack. Until the underlying issues are fixed in
>>> OCCT (and later OCE), this is the best I can do.
>>>
>>> If we can get this hack incorporated with the nightly Windows
>>> build that would be great. I did some testing and STEP models
>>> with non-ASCII characters in the filename now appear in the
>>> 3D viewer.  More users testing would be welcome; I'd like to
>>> have some certainly that I didn't introduce and unwanted
>>> side-effects.
>>>
>>> The tool kicad2step will require a little tweaking to get it
>>> working since I didn't fix its UTF8 issues when I fixed
>>> the problem in the rest of kicad. I'll send a patch for that
>>> soon.
>>>
>>> - Cirilo
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp