← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Refactor LAYER_ID to be the one and only layer definition



I misunderstood your original intent.  I don't think cluttering the
board layer enums with all of the virtual layer and schematic layer
enums is a good idea.  It just seems like overkill to me.  I thought you
were going to create a separate enum for virtual board layers.  You
could always start the virtual board layer enums from the last board
layer enum if you need unique enums.  I would also prefer the schematic
layer enums be separate from the board layer enums for clarity.  Anyone
else have any thoughts on this?



On 3/12/2017 11:24 PM, Jon Evans wrote:
> Hi all,
> Per the other thread, this patch unifies the layer definitions between
> Pcbnew, GerbView, and Eeschema.  It removes the need for ITEM_GAL_LAYER
> and some other macros, and it will simplify the implementation of
> cross-application color themes and using GAL in multiple applications.
> Note that this patch introduces some temporary weirdness in a few
> places, such as in COLORS_DESIGN_SETTINGS (there is now a single array
> for color storage, but it's still referred to by two sets of
> getters/setters).  This is because I wanted to keep this refactor as
> simple as possible, as I plan to follow it up with an overhaul of color
> settings when I share my color themes work.  I didn't want to do work
> that I would soon end up getting rid of anyway.
> Best,
> Jon
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

Follow ups