← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH]: Calculator: Simplify color code tolerance chooser + typo

 

Diego,

Your patch has been committed to the master branch.  Thank you for your
contribution to KiCad.

Cheers,

Wayne

On 2/25/2017 1:25 AM, Diego Herranz wrote:
> Hi,
> 
> Commit message:
> "
> Since for this tool the only difference for different tolerances
> is the 4th band, which is present for tolerance <= 2% and not
> present for 10%/5%, reduce radio choices to those two groups for
> clarity.
> 
> Fix a typo (4rd -> 4th) and rename one variable to make it
> more descriptive as well.
> "
> 
> In my opinion, reducing the number of tolerance choices makes sense
> and makes it easier to understand, however, I understand that this is
> subjective and others may think differently.
> 
> If you didn't want to include these changes, please let me know and I'll
> create another patch for the typo only.
> 
> Thanks,
> Diego
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


References