← Back to team overview

kicad-developers team mailing list archive

Re: Patch to compile _pcbnew.kiface only once

 

I have some time to do testing on this now that the stable package is
finished.

Simon, please resend if possible and I'll take a look this weekend.

Adam Wolf

On Thu, Mar 16, 2017, 5:05 PM Simon Wells <swel024@xxxxxxxxx> wrote:

> the problem is most of the python bundling crap is in patches (and
> yeah it is a bit hackish) wwas passed off to adam for testing but he
> never came back. but its also reliant on the python build not being
> broken. It is also as unhackish as it will get due to how cmake works,
> althought we MAY be able to push something upstream to cmake to fix
> DUE to the python bundling guidelines released by apple but i don't
> know whether they give a damn about them. and whats required to follow
> apples guidelides re python bundling.
>
>
>
> On 17 March 2017 at 10:35, Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx>
> wrote:
> > As I said before, I plan to work on the whole python packaging stuff as
> discussed below if no one else volunteers to do before.
> > I had some look around on how to do this, but I didn’t find any
> out-of-the-box solution which could be integrated quickly.
> > Unfortunately, I am still busy with other (non KiCad) things and it will
> still take a few weeks until I can start working on it (I hope during
> easter holidays)…
> >
> >> On 16 Mar 2017, at 22:08, Chris Pavlina <pavlina.chris@xxxxxxxxx>
> wrote:
> >>
> >> I'm of two minds on this. On one hand, I'd like to disable scripting on
> >> the macOS nightlies until it's fixed, so macOS users still *have*
> >> nightlies. On the other hand, I worry that doing so will remove
> >> motivation to actually fix it.
> >>
> >> Is anyone actually _actively working on a fix_? I keep seeing chatter
> >> about this, but no actual attempts to fix it.
> >>
> >> Honestly I think the patch that broke the build should be reverted until
> >> a fix can be prepared, but considering who submitted it, I doubt I'll
> >> have any say there.
> >>
> >>
> >> On Thu, Mar 16, 2017 at 04:56:14PM -0400, Jean-Paul Louis wrote:
> >>> I agree 150% with Bernhard.
> >>>
> >>> A disabled Python is 150% better than no new build at all.
> >>>
> >>> I do not understand why OS X users are considered second class
> citizens.
> >>>
> >>> Just my $0.02,
> >>> Jean-Paul
> >>> N1JPL
> >>>
> >>>
> >>>
> >>>> On Mar 16, 2017, at 2:06 PM, Bernhard Stegmaier <
> stegmaier@xxxxxxxxxxxxx> wrote:
> >>>>
> >>>> I have just seen people on the forum complaining that OSX nightlies
> still don’t build.
> >>>>
> >>>> @Simon:
> >>>> Do you intend to push your changes, no matter how hackish?
> >>>> Might at least be a start to work with.
> >>>>
> >>>> Or, just disable python scripting at all until the whole python
> bundling has been sorted out?
> >>>> Having no python scripting is better than having no build or a build
> where it doesn’t work right...
> >>>>
> >>>>
> >>>> Regards,
> >>>> Bernhard
> >>>>
> >>>>> On 21 Feb 2017, at 18:56, Simon Wells <swel024@xxxxxxxxx> wrote:
> >>>>>
> >>>>> I have previously sent a patch to adam for testing that bundled
> >>>>> python. but it was a bit hackish as since python is a system lib
> >>>>> bundleutilies doesn't copy it.
> >>>>>
> >>>>> On 21 February 2017 at 21:28, Bernhard Stegmaier
> >>>>> <stegmaier@xxxxxxxxxxxxx> wrote:
> >>>>>>
> >>>>>> On 21 Feb 2017, at 00:31, Wayne Stambaugh <stambaughw@xxxxxxxxx>
> wrote:
> >>>>>>
> >>>>>> On 2/20/2017 6:27 PM, Nick Østergaard wrote:
> >>>>>>
> >>>>>> 2017-02-20 23:48 GMT+01:00 Bernhard Stegmaier <
> stegmaier@xxxxxxxxxxxxx>:
> >>>>>>
> >>>>>> How is this done on Windows?
> >>>>>> You also don’t have a global filesystem with one Python there where
> you just
> >>>>>> copy it into the right place… where does the Windows installer put
> those
> >>>>>> files and how do you use them from some installed Python? Are there
> issues
> >>>>>> with library paths of the library dependencies that come with KiCAD
> when
> >>>>>> used from an external Python?
> >>>>>>
> >>>>>>
> >>>>>> I am not aware of any issues with it on windows, but I don't really
> use
> >>>>>> windows.
> >>>>>>
> >>>>>> People have requested to include pip with the windows install, and
> >>>>>> that is done now, so I assume that at least something works.
> >>>>>>
> >>>>>> I am not sure if the user uses the shell inside pcbnew or calls the
> >>>>>> python bundled with the installer. The file system layout is
> basically
> >>>>>> as on linux, just inside the install destination folder.
> >>>>>>
> >>>>>>
> >>>>>> Would something like this work on osx rather than trying to fit
> into an
> >>>>>> existing python install?  It might prove to be more reliable.  At
> least
> >>>>>> you would always have a known python build.
> >>>>>>
> >>>>>>
> >>>>>> Yes, that’s probably the only way to do it in a safe way for the
> bundle
> >>>>>> (and, as Adam said how Apple requires it).
> >>>>>> Currently only wxPython packages and the pcbnew .so are copied into
> the
> >>>>>> bundle.
> >>>>>> There is no (matching) python installation contained/copied.
> >>>>>>
> >>>>>> This seems to be sufficient to at least run the python console from
> inside
> >>>>>> pcbnew with some external python installation - if the python
> version used
> >>>>>> to build the bundle and the one on the target system are compatible.
> >>>>>> However, the last time I tried it the python console was really
> unusable for
> >>>>>> me, because you couldn’t even type some keys (menu hotkeys always
> trigger
> >>>>>> the menu action).
> >>>>>> Don’t know if that has been fixed meanwhile.
> >>>>>>
> >>>>>> So, I think this whole python stuff needs a big overhaul on macOS
> for both
> >>>>>> types of scripting.
> >>>>>> I will work on it when I have some spare time.
> >>>>>> If someone else is going to work on that please drop me a note, so
> that we
> >>>>>> don’t do it twice…
> >>>>>>
> >>>>>>
> >>>>>> Regards,
> >>>>>> Bernhard
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> _______________________________________________
> >>>>>> Mailing list: https://launchpad.net/~kicad-developers
> >>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>>>>> More help   : https://help.launchpad.net/ListHelp
> >>>>>>
> >>>>
> >>>>
> >>>> _______________________________________________
> >>>> Mailing list: https://launchpad.net/~kicad-developers
> >>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>>> More help   : https://help.launchpad.net/ListHelp
> >>>
> >>>
> >>> _______________________________________________
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Follow ups

References