← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Finish GAL zone tool

 

Hi John,

I am very grateful for the patches. It is a well-thought refactor, I
like the introduced changes. Your patches have just been committed,
thanks again!

Cheers,
Orson

On 03/22/2017 02:05 PM, John Beard wrote:
> Hi,
> 
> Here's a patch set to add the final pieces of the GAL zone tool: close
> outline and delete last corner.
> 
> This takes the form of a major re-cast of the drawZone event loop,
> which now uses a preview item to show the zone in progress and a
> geometry manager to decouple the construction from the the preview and
> the end result.
> 
> I chose this way, as the existing GAL event loop was very large and
> unwieldy. Adding modifiers keys and additional line contraints (e.g.
> 90 degrees) will be much easier when the parts are separated. Also the
> preview item and the geometry manager are reusable for other GAL tools
> (and not only in Pcbnew).
> 
> This is preceded by moving the DIRECTION45 class into common, as this
> is useful for the generic polygon preview, and has no dependencies
> other than standard primitives.
> 
> Cheers,
> 
> John
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Attachment: signature.asc
Description: OpenPGP digital signature


References