kicad-developers team mailing list archive

[Maciej Sumiński <maciej.suminski@xxxxxxx>]

TL;DR: Everything seems fine, I am going to merge the branch today.

For the record: I got the board that was showing the differences. I
refilled zones using the master branch, then once again with the polygon
refactor patch applied. Diff of zone polygons shows no difference.

There were differences between the zones in the original file and the
just refilled, so there could be a change in the filling algorithm in
the meantime.

I am going to merge the branch soon. Thank you Alejandro, I know it was
a rough road, but we are really grateful for your work. Well done!

Regards,
Orson

On 03/23/2017 09:19 AM, Maciej Sumiński wrote:
> Finally I had some time to test the branch and I could not find any
> problems, hence I would like to merge it. Let me know if there are any
> objections.
> 
> @Nick:
> Could you give more details? I placed keepout zones and refilled zones
> for all demo boards, and every time I get exactly the same zones (diffed
> two .kicad_pcb files).
> 
> Regards,
> Orson
> 
> On 02/18/2017 08:13 PM, Nick Østergaard wrote:
>> I have noticed that Alejandro's branch does not have a clearance
>> distance to a keepout zone, which the old filling algorithm has.
>>
>> I am not sure what is really desired, but this could potentially break
>> old designs, although I like the new way where the zone goes to the
>> keepout edge.
>>
>> 2017-02-17 20:24 GMT+01:00 jp charras <jp.charras@xxxxxxxxxx>:
>>> Le 17/02/2017 à 19:41, Alejandro Garcia Montoro a écrit :
>>>> Hi!
>>>>
>>>> The errors were caused by some asserts that contained functions that needed to be called... My bad.
>>>> Now the asserts are gone and the errors are handled via out_of_range exceptions (they were related
>>>> with possible illegal memory access),
>>>>
>>>> JP, I finally saw the zone filling error in the release build!
>>>>
>>>> Nick and JP, if you can pull and test the branch again and see if the errors you saw are fixed, that
>>>> would be great. Thank you.
>>>>
>>>> Best,
>>>> Alejandro
>>>
>>>
>>> At first glance, the issues I previously saw are gone.
>>> Thanks.
>>>
>>>
>>> --
>>> Jean-Pierre CHARRAS
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Attachment: signature.asc
Description: OpenPGP digital signature