kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Fabrizio,

I just attempt to apply this patch and both `git am` and `patch` are
failing to apply the patch.  Please rebase and resend it.

Thanks,

Wayne

On 3/28/2017 4:06 AM, Fabrizio Tappero wrote:
> Hi guys,
> OK, fixed all problems ;-)
> 
> Inline image 1
> 
> Please note that, as rightly suggested, the vertical position section
> has been swapped and that might require a small code modification, not
> completely sure about it.
> 
> In my opinion, I think "(degrees)" should not be plural and should not
> between brackets but if you like it this way so be it.
> 
> New patch in attachment
> 
> cheers
> Fabrizio
> 
> 
> 
> 
> 
> 
> On Tue, Mar 28, 2017 at 12:41 AM, Aaron Pelly
> <apelly@xxxxxxxxxxxxxxxxxxx <mailto:apelly@xxxxxxxxxxxxxxxxxxx>> wrote:
> 
>     Vertical position could probably do with swapping the align bottom and
>     align top radio buttons too; seems more logical.
> 
>     (This time to the list. Sorry Wayne.)
> 
>     On 28/03/17 06:12, Wayne Stambaugh wrote:
>     > Please change "Orientation, degree" to "Orientation (degrees)"
>     >
>     > The spacing still isn't correct between the "Font Size", "X Position",
>     > and "Y Position" controls.  There is more space between the "Font
>     Size"
>     > and "X Position controls than there is between the "X Position" and "Y
>     > Position" controls.
>     >
>     > Thanks,
>     >
>     > Wayne
>     >
>     > On 3/27/2017 12:20 PM, Fabrizio Tappero wrote:
>     >> here the current look
>     >>
>     >> Inline image 1
>     >>
>     >> On Mon, Mar 27, 2017 at 6:17 PM, Fabrizio Tappero
>     >> <fabrizio.tappero@xxxxxxxxx <mailto:fabrizio.tappero@xxxxxxxxx>
>     <mailto:fabrizio.tappero@xxxxxxxxx
>     <mailto:fabrizio.tappero@xxxxxxxxx>>> wrote:
>     >>
>     >>     Hi Wayne,
>     >>     sure no problem. Here you go.
>     >>
>     >>     Let me know if you want something else to be changed.
>     >>
>     >>     cheers
>     >>     Fabrizio
>     >>     PS I do not seem to understand how to change the spacing of
>     the font
>     >>     size and X pos elements...
>     >>
>     >>     On Mon, Mar 27, 2017 at 4:12 PM, Wayne Stambaugh
>     >>     <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
>     <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>> wrote:
>     >>
>     >>         Hey Fabrizio,
>     >>
>     >>         Sorry I didn't comment on this sooner but I've been busy.  I
>     >>         have a few
>     >>         comments:
>     >>
>     >>         "Custom Fields" should just read "Fields".  The first four
>     >>         fields are
>     >>         mandatory so the word custom is misleading.
>     >>
>     >>         The "Assert" button is confusing.  This button tests the
>     >>         component name
>     >>         but does not updated the component.  "Verify",
>     "Validate", or "Test"
>     >>         would be more descriptive.
>     >>
>     >>         Please change "deg" to "degrees" in the orientation control.
>     >>         I'm not
>     >>         sure "deg" is a standard abbreviation for degrees in the same
>     >>         way the
>     >>         "mm" is the standard abbreviation for millimeters.
>     >>
>     >>         I know this isn't specific to your changes but I would
>     >>         appreciate if you
>     >>         would fix the spacing between the "Font Size", "X
>     Position", and "Y
>     >>         Position" controls.  It's been on my todo list for a long
>     time so it
>     >>         would be helpful if you could fix this.
>     >>
>     >>         Thanks,
>     >>
>     >>         Wayne
>     >>
>     >>         On 3/27/2017 9:48 AM, Fabrizio Tappero wrote:
>     >>         > ​Hello,
>     >>         > This patch fixes several labeling errors with the "edit
>     properties" window.
>     >>         > Preview of the windows that you get after the patch is
>     this:
>     >>         >
>     >>         > ​Inline image 1​
>     >>         >
>     >>         > ​Cheers
>     >>         > Fabrizio
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>