kicad-developers team mailing list archive

[Maciej Sumiński <maciej.suminski@xxxxxxx>]

Hi John,

Good catch, I have committed both patches. I guess it has not been
noticed, as most people do not really pay attention to rotation
direction, it is only up to 3 hotkey presses to get any of the 90*
multiples.

Anyway, it is surely better to perform what is written on the label.

Cheers,
Orson

On 03/30/2017 01:48 PM, John Beard wrote:
> This will all be moot when GAL hotkeys can be remapped, since users
> that care can swap them over.
> 
> In any case, the attached patch can be applied after the correction
> above to also swap 'R' and 'Shift-R', so that R is CCW.
> 
> Cheers,
> 
> John
> 
> 
> On Thu, Mar 30, 2017 at 7:32 PM, Clemens Koller <cko@xxxxxxxxx> wrote:
>> Hello, Jon!
>>
>> On 2017-03-30 11:07, John Beard wrote:
>>> Hi,
>>> When CW/CCW rotation was added in GAL (7045ed92f), the tool actions
>>> didn't correct for the internal represention of angles, so CW/CCW were
>>> reversed. This patch fixes that. I failed to notice the comment "//
>>> TODO rotate CCW" was wrong. On the other hand, it seems only one
>>> person actually noticed since Feb 4th :-p, including myself.
>>>
>>> Now, eeschema standard rotate (R) is CW, but legacy Pcbnew "Rotate+"
>>> (also R) is CCW.
>>>
>>> I have not changed the hotkey assignment for the GAL actions, so it
>>> now matches eeschema, not legacy mode. I think that CW-default is the
>>> better default?
>>
>> I would strongly prefer to use the mathematically positive rotation (CCW) by default.
>>
>> R -> CCW (Rotate +)    and    Shift-R -> CW (Rotate -)
>>
>> Simply because it's what the majority of applications use...
>>
>> Regards,
>>
>> Clemens
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

Attachment: signature.asc
Description: OpenPGP digital signature