kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #29056
Re: [PATCH] better UI experience (properties window)
thanks a lot Wayne,
cheers
Fabrizio
On Fri, Mar 31, 2017 at 10:27 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx>
wrote:
> Fabrizio,
>
> I pushed your patch to the master branch. Thank you for your contribution.
>
> Cheers,
>
> Wayne
>
> On 3/30/2017 7:28 AM, Fabrizio Tappero wrote:
> > Hi Wayne,
> > OK, I fixed the problem. Please refer to the patch in attachment, it
> > will produce this:
> >
> > Inline image 1
> >
> > I tried to use the extra ASCII degree simbol but I could not compile
> it.
> >
> > PLEASE pay attention to the fact that the vertical position part is now
> > "top center bottom"
> >
> > Cheers
> > Fabrizio
> >
> > On Tue, Mar 28, 2017 at 7:38 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx
> > <mailto:stambaughw@xxxxxxxxx>> wrote:
> >
> > Hey Fabrizio,
> >
> > No problem. Thank you for the update.
> >
> > Cheers,
> >
> > Wayne
> >
> > On 3/28/2017 1:41 PM, Fabrizio Tappero wrote:
> > > Hi Wayne,
> > > yeah I have wrongly inserted the patch file into it. I can fix it
> but I
> > > need two days to get back to my PC.
> > >
> > > I will get back to you on Thursday
> > >
> > > cheers
> > > Fabrizio
> > >
> > >
> > > On Tue, Mar 28, 2017 at 6:43 PM, Wayne Stambaugh <
> stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
> > > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>>
> wrote:
> > >
> > > Hey Fabrizio,
> > >
> > > Still no luck. Here is the `git am` output:
> > >
> > > $ git am <
> > > /c/Users/Wayne/Archive/temp/kicad/patches/better-
> properties-wind.patch
> > > Applying: commit 49df104f1b7c7e7ac4a1087a7dc3bfef053fcc33
> > > error: better-properties-wind.patch: does not exist in index
> > > error: patch failed:
> > > eeschema/dialogs/dialog_edit_component_in_schematic_fbp.cpp:45
> > > error: eeschema/dialogs/dialog_edit_
> component_in_schematic_fbp.cpp:
> > > patch does not apply
> > > error: patch failed:
> > > eeschema/dialogs/dialog_edit_component_in_schematic_fbp.
> fbp:480
> > > error: eeschema/dialogs/dialog_edit_
> component_in_schematic_fbp.fbp:
> > > patch does not apply
> > > Patch failed at 0001 commit 49df104f1b7c7e7ac4a1087a7dc3bf
> ef053fcc33
> > > The copy of the patch that failed is found in:
> .git/rebase-apply/patch
> > > When you have resolved this problem, run "git am --continue".
> > > If you prefer to skip this patch, run "git am --skip" instead.
> > > To restore the original branch and stop patching, run "git am
> --abort".
> > >
> > >
> > > On 3/28/2017 12:37 PM, Fabrizio Tappero wrote:
> > > > Hi Wayne,
> > > > here you go. I am having some problems with this PC.
> > > >
> > > > cheers
> > > > Fabrizio
> > > >
> > > >
> > > >
> > > >
> > > > On Tue, Mar 28, 2017 at 4:40 PM, Wayne Stambaugh <
> stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
> > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>
> > > > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
> > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>>> wrote:
> > > >
> > > > Fabrizio,
> > > >
> > > > I just attempt to apply this patch and both `git am` and
> `patch` are
> > > > failing to apply the patch. Please rebase and resend it.
> > > >
> > > > Thanks,
> > > >
> > > > Wayne
> > > >
> > > > On 3/28/2017 4:06 AM, Fabrizio Tappero wrote:
> > > > > Hi guys,
> > > > > OK, fixed all problems ;-)
> > > > >
> > > > > Inline image 1
> > > > >
> > > > > Please note that, as rightly suggested, the vertical
> position section
> > > > > has been swapped and that might require a small code
> modification, not
> > > > > completely sure about it.
> > > > >
> > > > > In my opinion, I think "(degrees)" should not be
> plural and should not
> > > > > between brackets but if you like it this way so be it.
> > > > >
> > > > > New patch in attachment
> > > > >
> > > > > cheers
> > > > > Fabrizio
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > On Tue, Mar 28, 2017 at 12:41 AM, Aaron Pelly
> > > > > <apelly@xxxxxxxxxxxxxxxxxxx <mailto:
> apelly@xxxxxxxxxxxxxxxxxxx>
> > <mailto:apelly@xxxxxxxxxxxxxxxxxxx <mailto:apelly@monkeymasters.
> co.nz>>
> > > <mailto:apelly@xxxxxxxxxxxxxxxxxxx <mailto:
> apelly@xxxxxxxxxxxxxxxxxxx>
> > <mailto:apelly@xxxxxxxxxxxxxxxxxxx <mailto:apelly@monkeymasters.
> co.nz>>>
> > > > <mailto:apelly@xxxxxxxxxxxxxxxxxxx <mailto:
> apelly@xxxxxxxxxxxxxxxxxxx>
> > > <mailto:apelly@xxxxxxxxxxxxxxxxxxx <mailto:
> apelly@xxxxxxxxxxxxxxxxxxx>>
> > > > <mailto:apelly@xxxxxxxxxxxxxxxxxxx
> > <mailto:apelly@xxxxxxxxxxxxxxxxxxx>
> > <mailto:apelly@xxxxxxxxxxxxxxxxxxx
> > <mailto:apelly@xxxxxxxxxxxxxxxxxxx>>>>> wrote:
> > > > >
> > > > > Vertical position could probably do with swapping
> > the align bottom and
> > > > > align top radio buttons too; seems more logical.
> > > > >
> > > > > (This time to the list. Sorry Wayne.)
> > > > >
> > > > > On 28/03/17 06:12, Wayne Stambaugh wrote:
> > > > > > Please change "Orientation, degree" to
> > "Orientation (degrees)"
> > > > > >
> > > > > > The spacing still isn't correct between the
> > "Font Size", "X Position",
> > > > > > and "Y Position" controls. There is more space
> > between the "Font
> > > > > Size"
> > > > > > and "X Position controls than there is between
> > the "X Position" and "Y
> > > > > > Position" controls.
> > > > > >
> > > > > > Thanks,
> > > > > >
> > > > > > Wayne
> > > > > >
> > > > > > On 3/27/2017 12:20 PM, Fabrizio Tappero wrote:
> > > > > >> here the current look
> > > > > >>
> > > > > >> Inline image 1
> > > > > >>
> > > > > >> On Mon, Mar 27, 2017 at 6:17 PM, Fabrizio
> Tappero
> > > > > >> <fabrizio.tappero@xxxxxxxxx
> > <mailto:fabrizio.tappero@xxxxxxxxx>
> > <mailto:fabrizio.tappero@xxxxxxxxx <mailto:fabrizio.tappero@
> gmail.com>>
> > > <mailto:fabrizio.tappero@xxxxxxxxx
> > <mailto:fabrizio.tappero@xxxxxxxxx>
> > <mailto:fabrizio.tappero@xxxxxxxxx <mailto:fabrizio.tappero@
> gmail.com>>>
> > > > <mailto:fabrizio.tappero@xxxxxxxxx
> > <mailto:fabrizio.tappero@xxxxxxxxx>
> > <mailto:fabrizio.tappero@xxxxxxxxx <mailto:fabrizio.tappero@
> gmail.com>>
> > > <mailto:fabrizio.tappero@xxxxxxxxx
> > <mailto:fabrizio.tappero@xxxxxxxxx>
> > <mailto:fabrizio.tappero@xxxxxxxxx
> > <mailto:fabrizio.tappero@xxxxxxxxx>>>>
> > > > > <mailto:fabrizio.tappero@xxxxxxxxx
> > <mailto:fabrizio.tappero@xxxxxxxxx>
> > <mailto:fabrizio.tappero@xxxxxxxxx <mailto:fabrizio.tappero@
> gmail.com>>
> > > > <mailto:fabrizio.tappero@xxxxxxxxx
> > <mailto:fabrizio.tappero@xxxxxxxxx>
> > <mailto:fabrizio.tappero@xxxxxxxxx <mailto:fabrizio.tappero@
> gmail.com>>>
> > > > > <mailto:fabrizio.tappero@xxxxxxxxx
> > <mailto:fabrizio.tappero@xxxxxxxxx>
> > > <mailto:fabrizio.tappero@xxxxxxxxx
> > <mailto:fabrizio.tappero@xxxxxxxxx>>
> > > <mailto:fabrizio.tappero@xxxxxxxxx
> > <mailto:fabrizio.tappero@xxxxxxxxx>
> > > <mailto:fabrizio.tappero@xxxxxxxxx
> > <mailto:fabrizio.tappero@xxxxxxxxx>>>>>> wrote:
> > > > > >>
> > > > > >> Hi Wayne,
> > > > > >> sure no problem. Here you go.
> > > > > >>
> > > > > >> Let me know if you want something else to
> > be changed.
> > > > > >>
> > > > > >> cheers
> > > > > >> Fabrizio
> > > > > >> PS I do not seem to understand how to
> > change the
> > > spacing of
> > > > > the font
> > > > > >> size and X pos elements...
> > > > > >>
> > > > > >> On Mon, Mar 27, 2017 at 4:12 PM, Wayne
> > Stambaugh
> > > > > >> <stambaughw@xxxxxxxxx
> > <mailto:stambaughw@xxxxxxxxx>
> > > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>
> > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
> > > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>>
> > > > <mailto:stambaughw@xxxxxxxxx
> > <mailto:stambaughw@xxxxxxxxx> <mailto:stambaughw@xxxxxxxxx
> > <mailto:stambaughw@xxxxxxxxx>>
> > > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
> > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>>>
> > > > > <mailto:stambaughw@xxxxxxxxx
> > <mailto:stambaughw@xxxxxxxxx>
> > > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>
> > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
> > > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>>
> > > > <mailto:stambaughw@xxxxxxxxx
> > <mailto:stambaughw@xxxxxxxxx> <mailto:stambaughw@xxxxxxxxx
> > <mailto:stambaughw@xxxxxxxxx>>
> > > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
> > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>>>>>
> wrote:
> > > > > >>
> > > > > >> Hey Fabrizio,
> > > > > >>
> > > > > >> Sorry I didn't comment on this sooner
> but
> > > I've been
> > > > busy. I
> > > > > >> have a few
> > > > > >> comments:
> > > > > >>
> > > > > >> "Custom Fields" should just read
> > "Fields". The
> > > > first four
> > > > > >> fields are
> > > > > >> mandatory so the word custom is
> misleading.
> > > > > >>
> > > > > >> The "Assert" button is confusing. This
> > button
> > > > tests the
> > > > > >> component name
> > > > > >> but does not updated the component.
> > "Verify",
> > > > > "Validate", or "Test"
> > > > > >> would be more descriptive.
> > > > > >>
> > > > > >> Please change "deg" to "degrees" in the
> > > orientation
> > > > control.
> > > > > >> I'm not
> > > > > >> sure "deg" is a standard abbreviation
> > for degrees
> > > > in the same
> > > > > >> way the
> > > > > >> "mm" is the standard abbreviation for
> > > millimeters.
> > > > > >>
> > > > > >> I know this isn't specific to your
> changes
> > > but I would
> > > > > >> appreciate if you
> > > > > >> would fix the spacing between the "Font
> > Size", "X
> > > > > Position", and "Y
> > > > > >> Position" controls. It's been on my
> todo
> > > list for
> > > > a long
> > > > > time so it
> > > > > >> would be helpful if you could fix this.
> > > > > >>
> > > > > >> Thanks,
> > > > > >>
> > > > > >> Wayne
> > > > > >>
> > > > > >> On 3/27/2017 9:48 AM, Fabrizio Tappero
> > wrote:
> > > > > >> > Hello,
> > > > > >> > This patch fixes several labeling
> errors
> > > with the
> > > > "edit
> > > > > properties" window.
> > > > > >> > Preview of the windows that you get
> > after the
> > > > patch is
> > > > > this:
> > > > > >> >
> > > > > >> > Inline image 1
> > > > > >> >
> > > > > >> > Cheers
> > > > > >> > Fabrizio
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > _______________________________________________
> > > > > Mailing list: https://launchpad.net/~kicad-developers
> > <https://launchpad.net/~kicad-developers>
> > > <https://launchpad.net/~kicad-developers
> > <https://launchpad.net/~kicad-developers>>
> > > > <https://launchpad.net/~kicad-developers
> > <https://launchpad.net/~kicad-developers>
> > > <https://launchpad.net/~kicad-developers
> > <https://launchpad.net/~kicad-developers>>>
> > > > > Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
> > > > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>>
> > > > > Unsubscribe : https://launchpad.net/~kicad-developers
> > <https://launchpad.net/~kicad-developers>
> > > <https://launchpad.net/~kicad-developers
> > <https://launchpad.net/~kicad-developers>>
> > > > <https://launchpad.net/~kicad-developers
> > <https://launchpad.net/~kicad-developers>
> > > <https://launchpad.net/~kicad-developers
> > <https://launchpad.net/~kicad-developers>>>
> > > > > More help : https://help.launchpad.net/ListHelp
> > <https://help.launchpad.net/ListHelp>
> > > <https://help.launchpad.net/ListHelp
> > <https://help.launchpad.net/ListHelp>>
> > > > <https://help.launchpad.net/ListHelp
> > <https://help.launchpad.net/ListHelp>
> > > <https://help.launchpad.net/ListHelp
> > <https://help.launchpad.net/ListHelp>>>
> > > > >
> > > >
> > > > _______________________________________________
> > > > Mailing list: https://launchpad.net/~kicad-developers
> > <https://launchpad.net/~kicad-developers>
> > > <https://launchpad.net/~kicad-developers
> > <https://launchpad.net/~kicad-developers>>
> > > > <https://launchpad.net/~kicad-developers
> > <https://launchpad.net/~kicad-developers>
> > > <https://launchpad.net/~kicad-developers
> > <https://launchpad.net/~kicad-developers>>>
> > > > Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
> > > > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> > <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>>
> > > > Unsubscribe : https://launchpad.net/~kicad-developers
> > <https://launchpad.net/~kicad-developers>
> > > <https://launchpad.net/~kicad-developers
> > <https://launchpad.net/~kicad-developers>>
> > > > <https://launchpad.net/~kicad-developers
> > <https://launchpad.net/~kicad-developers>
> > > <https://launchpad.net/~kicad-developers
> > <https://launchpad.net/~kicad-developers>>>
> > > > More help : https://help.launchpad.net/ListHelp
> > <https://help.launchpad.net/ListHelp>
> > > <https://help.launchpad.net/ListHelp
> > <https://help.launchpad.net/ListHelp>>
> > > > <https://help.launchpad.net/ListHelp
> > <https://help.launchpad.net/ListHelp>
> > > <https://help.launchpad.net/ListHelp
> > <https://help.launchpad.net/ListHelp>>>
> > > >
> > > >
> > >
> > >
> >
> >
>
>
References
-
[PATCH] better UI experience (properties window)
From: Fabrizio Tappero, 2017-03-27
-
Re: [PATCH] better UI experience (properties window)
From: Wayne Stambaugh, 2017-03-27
-
Re: [PATCH] better UI experience (properties window)
From: Fabrizio Tappero, 2017-03-27
-
Re: [PATCH] better UI experience (properties window)
From: Fabrizio Tappero, 2017-03-27
-
Re: [PATCH] better UI experience (properties window)
From: Wayne Stambaugh, 2017-03-27
-
Re: [PATCH] better UI experience (properties window)
From: Aaron Pelly, 2017-03-27
-
Re: [PATCH] better UI experience (properties window)
From: Fabrizio Tappero, 2017-03-28
-
Re: [PATCH] better UI experience (properties window)
From: Wayne Stambaugh, 2017-03-28
-
Re: [PATCH] better UI experience (properties window)
From: Fabrizio Tappero, 2017-03-28
-
Re: [PATCH] better UI experience (properties window)
From: Wayne Stambaugh, 2017-03-28
-
Re: [PATCH] better UI experience (properties window)
From: Fabrizio Tappero, 2017-03-28
-
Re: [PATCH] better UI experience (properties window)
From: Wayne Stambaugh, 2017-03-28
-
Re: [PATCH] better UI experience (properties window)
From: Fabrizio Tappero, 2017-03-30
-
Re: [PATCH] better UI experience (properties window)
From: Wayne Stambaugh, 2017-03-31
