← Back to team overview

kicad-developers team mailing list archive

Re: Symbol library editor UI refactor

 

Thank you Nick, I did not have ACTION_MENU flag enabled. It should be
correct now.

Regards,
Orson

On 04/03/2017 07:50 AM, Nick Østergaard wrote:
> Hi Orson,
> 
> I just attempted to build your branch, but it fals, I am on commit
> 2198cd592fd6982255b336d3bc21ee9db9bf0ba7 which is currently HEAD of
> your libedit branch on lp.
> 
> kicad-git/pcbnew/swig/pcbnew_action_plugins.cpp: In member function
> 'void PCB_EDIT_FRAME::OnActionPlugin(wxCommandEvent&)':
> kicad-git/pcbnew/swig/pcbnew_action_plugins.cpp:371:26: error: 'class
> PCB_SCREEN' has no member named 'SetModify'; did you mean
> 'SetModified'?
>              GetScreen()->SetModify();
> 
> 
> Nick
> 
> 2017-04-02 17:46 GMT+02:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:
>> Hey Orson,
>>
>> I'm fine with using PART_LIBS object for now.  Once the symbol library
>> table is in play, the only code that should be using PART_LIBS is the
>> code that remaps the symbols in the schematic from the current look up
>> method over to the symbol library table.
>>
>> Thanks,
>>
>> Wayne
>>
>> On 4/1/2017 7:14 PM, Maciej Suminski wrote:
>>> Hi Wayne,
>>>
>>> Yes, I used the PART_LIBS object, as it seemed to be used everywhere
>>> else. Obviously, I will adjust my code when SYMBOL_LIB_TABLE is ready,
>>> but I would prefer to do it after it is adopted by other components.
>>> This way I will have some examples that I could read, and
>>> SYMBOL_LIB_TABLE is likely to be well tested, so I am going to have less
>>> doubts when I face problems.
>>>
>>> Cheers,
>>> Orson
>>>
>>> On 03/31/2017 12:51 AM, Wayne Stambaugh wrote:
>>>> Hey Orson,
>>>>
>>>> I'm guessing you used the current PART_LIBS object instead of
>>>> SYMBOL_LIB_TABLE to access the symbol libraries.  This method will soon
>>>> be obsolete.  Will you have the time to help me with the transition?  I
>>>> am willing to do it but I'm not familiar with the new symbol library
>>>> editor code (yet).  My goal is to get the new symbol library table code
>>>> in place for populating schematics and then start working on the editor,
>>>> viewer, chooser, and any other remaining code the uses PART_LIBS to
>>>> access symbol libraries.  I'll see if I can find the time this weekend
>>>> to try out the new editor.
>>>>
>>>> Cheers,
>>>>
>>>> Wayne
>>>>
>>>> On 3/30/2017 6:12 PM, Maciej Suminski wrote:
>>>>> Here it comes, raised from the dead, the new UI for symbol library
>>>>> editor [1]!
>>>>>
>>>>> KiCad is a really fast moving target, so it has taken me plenty of time
>>>>> to rebase the branch. Actually there is a completely new approach
>>>>> inside, I hope it will be more robust.
>>>>>
>>>>> I still need to replace the head commit, as it has not got Wayne's
>>>>> approval, but it should not be a huge change. What I need now is a few
>>>>> brave testers, as I would like to merge the code as soon as I fix the
>>>>> problematic commit.
>>>>>
>>>>> Regards,
>>>>> Orson
>>>>>
>>>>> 1. https://code.launchpad.net/~orsonmmz/kicad/+git/kicad/+ref/libedit
>>>>>
>>>>> On 12/05/2016 05:52 PM, Maciej Sumiński wrote:
>>>>>> Since some time we have been working on eeschema library editor with the
>>>>>> goal of simplifying the user interface. Now it is available for
>>>>>> beta testing [1] and I would appreciate some feedback.
>>>>>>
>>>>>> Changes:
>>>>>> - symbol tree widget (thanks to Michele Castellana)
>>>>>> - opening multiple components at the same time
>>>>>> - creating a new library adds it to the project libraries
>>>>>> - cut/copy/paste symbols between libraries
>>>>>> - most of the actions are available in the top menu now
>>>>>>
>>>>>> I have modified a few icons too (import/export/save part), though they
>>>>>> need pixel-accurate scaling to look fine, so for now they are just an
>>>>>> idea to be discussed.
>>>>>>
>>>>>> I invite you to build the code and take it for a test drive, but if all
>>>>>> you want is a quick overview of the changes, then there is a short
>>>>>> screencast too [2].
>>>>>>
>>>>>> Regards,
>>>>>> Orson
>>>>>>
>>>>>> 1. https://code.launchpad.net/~orsonmmz/kicad/+git/kicad/+ref/libedit
>>>>>> 2. https://vimeo.com/194371466
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Attachment: signature.asc
Description: OpenPGP digital signature


References