← Back to team overview

kicad-developers team mailing list archive

PATCH: add comments to VRML2 parser source

 

The attached patch adds some comments to the VRML2 parser.

- Cirilo
From 00a847edfe1c2fd5773d36a9ae93319de8108363 Mon Sep 17 00:00:00 2001
From: Cirilo Bernardo <cirilo.bernardo@xxxxxxxxx>
Date: Sun, 16 Apr 2017 00:23:04 +0000
Subject: [PATCH] Added comments on skipped patterns in VRML2 parser

---
 plugins/3d/vrml/v2/vrml2_base.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/plugins/3d/vrml/v2/vrml2_base.cpp b/plugins/3d/vrml/v2/vrml2_base.cpp
index d0e3bee00..e26aad188 100644
--- a/plugins/3d/vrml/v2/vrml2_base.cpp
+++ b/plugins/3d/vrml/v2/vrml2_base.cpp
@@ -460,6 +460,7 @@ bool WRL2BASE::ReadNode( WRLPROC& proc, WRL2NODE* aParent, WRL2NODE** aNode )
         return true;
     }
 
+    // pattern to skip:  PROTO name list
     if( !glob.compare( "PROTO" ) )
     {
         if( !proc.ReadName( glob ) || !proc.DiscardList() )
@@ -479,6 +480,7 @@ bool WRL2BASE::ReadNode( WRLPROC& proc, WRL2NODE* aParent, WRL2NODE** aNode )
         return true;
     }
 
+    // pattern to skip:  EXTERNPROTO name1 name2 list
     if( !glob.compare( "EXTERNPROTO" ) )
     {
         if( !proc.ReadName( glob ) || !proc.ReadName( glob ) || !proc.DiscardList() )
@@ -498,6 +500,7 @@ bool WRL2BASE::ReadNode( WRLPROC& proc, WRL2NODE* aParent, WRL2NODE** aNode )
         return true;
     }
 
+    // pattern to skip:  ROUTE glob1 glob2 glob3
     if( !glob.compare( "ROUTE" ) )
     {
         if( !proc.ReadGlob( glob ) || !proc.ReadGlob( glob ) || !proc.ReadGlob( glob ) )
-- 
2.11.0


Follow ups