kicad-developers team mailing list archive

[Joseph Chen <joseph.chen59@xxxxxxxxx>]

Attached is a trivial patch that puts a check mark on  the check-box of 
"No copper pour" when a new "Keepout Area Properties" dialog window is 
popped up.

The problem:

With pcbnew, when a new keepout zone was created, the dialog window of 
"Keepout Area Properties" popped up.  This dialog window would leave 
with an unchecked box of "No copper pour".  A busy or a novice user 
would have missed the opportunity to manually put an extra check-mark on 
one of some busy options.  As a result, the keepout zone would never be 
able to work to keep the copper-pour out of the designated area, causing 
the user to false-fully think pcbnew having a bug.

As an user, this new change would have saved me from a week-long's grief 
when I missed the check-box during creating a keeoput zone in my PCB 
layout.  The miss even caused me to file a bug report, which only was 
invalidated by gurus after some efforts.

This new patch has fixed the problem described above, has passes my unit 
test running Ubuntu16.04.

Thus I am submitting this patch.


--JC



>From 6dea10f729793e0d5ccce08c1a6acfa1b374f6b0 Mon Sep 17 00:00:00 2001
From: "Joseph Y. Chen" <joseph.chen59@xxxxxxxxx>
Date: Fri, 21 Apr 2017 23:05:11 -0600
Subject: [PATCH] changed so 'No copper pour' set as default in a new
 keepout-zone

Signed-off-by: Joseph Y. Chen <joseph.chen59@xxxxxxxxx>
---
 pcbnew/class_zone_settings.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pcbnew/class_zone_settings.cpp b/pcbnew/class_zone_settings.cpp
index 7aa2fc7..41a48bf 100644
--- a/pcbnew/class_zone_settings.cpp
+++ b/pcbnew/class_zone_settings.cpp
@@ -64,7 +64,7 @@ ZONE_SETTINGS::ZONE_SETTINGS()
     m_cornerRadius = 0;
 
     SetIsKeepout( false );
-    SetDoNotAllowCopperPour( false );
+    SetDoNotAllowCopperPour( true );
     SetDoNotAllowVias( true );
     SetDoNotAllowTracks( true );
 }
-- 
2.7.4