← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Check required libraries in FindwxWidgets.cmake

 

Simon,

Are you saying this patch will not work as is or are there other steps
we need to do to get this correct?

Wayne

On 4/24/2017 11:59 AM, Simon Richter wrote:
> Hi,
> 
> On 24.04.2017 14:55, Jan Mrázek wrote:
> 
>> I have updated my patch for this problem and managed to get it into
>> CMake upstream. Since it will be included in CMake 3.9 and I think KiCAD
>> is not going to switch to new version of CMake soon, I think it might be
>> useful to include this patch also in the KiCADs copy of FindwxWidgets.cmake.
> 
> Ideally the one in KiCad should be identical to the one in CMake
> upstream, except
> 
>  - the licence text needs to be included in full, while the CMake source
> package refers to a common copy
>  - files used from the CMake distribution (IIRC, FindwxWidgets.cmake
> uses FPHSA and UsewxWidgets.cmake) need to be referenced without path
> and suffix.
> 
> The last time we synchronized there were commits from me in both wx and
> KiCad repositories.
> 
>    Simon
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Follow ups

References