kicad-developers team mailing list archive

[Simon Richter <Simon.Richter@xxxxxxxxxx>]

Hi,

On 25.04.2017 17:23, Tomasz Wlostowski wrote:

> I've pushed the branch [1] containing a rewrite of the pcbnew's
> connectivity algorithm. By this algorithm, I mean:

There is a new compiler warning:

pcbnew/edit.cpp: In member function 'void
PCB_EDIT_FRAME::OnSelectTool(wxCommandEvent&)':
/home/geier/OSS/kicad/pcbnew/edit.cpp:1446:9: warning: this 'else'
clause does not guard... [-Wmisleading-indentation]
         else
         ^~~~
pcbnew/edit.cpp:1448:13: note: ...this statement, but the latter is
misleadingly indented as if it is guarded by the 'else'
             Compile_Ratsnest( &dc, true );
             ^~~~~~~~~~~~~~~~

You removed the condition and braces around the Compile_Ratsnest call in
commit aac791a2, making it unconditional, but the indentation suggests
that it is covered by the if above it.

   Simon

Attachment: signature.asc
Description: OpenPGP digital signature