kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #29391
Re: Eagle XML parsing moved to common
-
To:
<kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
From:
Maciej Sumiński <maciej.suminski@xxxxxxx>
-
Date:
Mon, 8 May 2017 11:09:28 +0200
-
Authentication-results:
spf=pass (sender IP is 188.184.36.46) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
In-reply-to:
<CAOjHwcW84jbTca6nx_fMz9S41=vU1BZ0w3Ef45ejvds-SvMtjg@mail.gmail.com>
-
Spamdiagnosticmetadata:
NSPM
-
Spamdiagnosticoutput:
1:99
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1
Hi Alejandro,
I am really sorry it has taken me so long to review the patch. I have
tested it and it seems to work correctly, so now it is merged.
I like the refactor changes, good job! I am also aware of the branch
containing initial work on Eagle schematic import, but it has to wait to
be more complete.
Cheers,
Orson
On 04/07/2017 02:13 PM, Alejandro Garcia Montoro wrote:
> Hi all,
>
> I'm working in the eeschema plugin for importing Eagle schematics :)
>
> I've decided to reuse the good work done in pcbnew, so this patch moves the
> XML parsing logic from there to common.
>
> It also replaces Boost.PropertyTree to wxXml to help a little bit with our
> quest against boost.
>
> I've tested some boards and the output of the plugin with the current logic
> and with this patch applied is exactly the same, but more tests are more
> than welcome.
>
> Hope this is useful.
>
> Best,
> Alejandro
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Attachment:
signature.asc
Description: OpenPGP digital signature
Follow ups
References