kicad-developers team mailing list archive

[Russell Oliver <roliver8143@xxxxxxxxx>]

Hi Tom,

Attached is an updated patch which moves the feature into a separate tool
class and rebased the latest master commit as of writing.

Also available at https://github.com/rustyoz/kicad/tree/position-relative

Regards
Russell

On Fri, May 5, 2017 at 12:18 AM Tomasz Wlostowski <tomasz.wlostowski@xxxxxxx>
wrote:

> On 30.04.2017 14:47, Russell Oliver wrote:
> > Hi Tom,
> >
> > sorry again,
> > Attached is a fixed patch.
>
> Hi Russell,
>
> I'd like to merge it. Few more comments:
> - check code indentation (you have a mix of tabs and spaces). uncrustify
> tool can do that for you.
> - the argument naming should follow the aArgument1, aArg2, etc. convention
> - the tool is relatively complex. consider creating a new tool class for
> it, the EDIT_TOOL class is already quite big.
>
> Best,
> Tom
>

Attachment: 0001-Add-Position-Relative-tool.patch
Description: Binary data