← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Component table text alignment

 

Patch has been submitted that fixes this.

On Mon, May 22, 2017 at 11:48 PM, Oliver Walters <
oliver.henry.walters@xxxxxxxxx> wrote:

> Andrey,
>
> They are. However there is logic when the table is being created to
> determine if the table already "knows" about a certain field. (Assigning an
> #ID to a field name). There's currently a bug where if the user chooses a
> field name that matches a default name, then it gets confused.
>
> On Mon, May 22, 2017 at 11:36 PM, Andrey Kuznetsov <kandrey89@xxxxxxxxx>
> wrote:
>
>> Why aren't fields enumerated by id #s instead of strings?
>>
>> On Mon, May 22, 2017 at 12:53 AM, Oliver Walters <
>> oliver.henry.walters@xxxxxxxxx> wrote:
>>
>>> Interesting edge case - this is a good find.
>>>
>>> Wayne, JP, etc:
>>>
>>> How best to handle user fields that are renamed to match the "default"
>>> fields (which depend on the locale of the user).
>>>
>>> I could add a special tag to the default fields or make them uppercase,
>>> etc, but that only shifts the problem to a different string comparison.
>>>
>>> Regards,
>>> Oliver
>>>
>>> On Mon, May 22, 2017 at 5:20 PM, Fabrizio Tappero <
>>> fabrizio.tappero@xxxxxxxxx> wrote:
>>>
>>>> hi Guys,
>>>> this is a gentle reminder that
>>>> ​ (for instance)​
>>>> a "description"
>>>> ​tag in the ​schematic
>>>> component
>>>> ​properties will be wrongly parsed by the component table view​er.
>>>>
>>>> ​Cheers
>>>> Fabrizio
>>>> ​
>>>>
>>>>
>>>> ​[image: Inline image 1]​
>>>>
>>>>
>>>> On Thu, May 18, 2017 at 2:46 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx>
>>>> wrote:
>>>>
>>>>> Oliver,
>>>>>
>>>>> I committed your patch.  Thank you for your contribution to KiCad.
>>>>>
>>>>> Cheers,
>>>>>
>>>>> Wayne
>>>>>
>>>>> On 5/15/2017 3:33 AM, Oliver Walters wrote:
>>>>> > Simple patch that left-aligns text in component table viewer
>>>>> >
>>>>> >
>>>>> >
>>>>> >
>>>>> > _______________________________________________
>>>>> > Mailing list: https://launchpad.net/~kicad-developers
>>>>> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>> > Unsubscribe : https://launchpad.net/~kicad-developers
>>>>> > More help   : https://help.launchpad.net/ListHelp
>>>>> >
>>>>>
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>
>>
>> --
>> Remember The Past, Live The Present, Change The Future
>> Those who look only to the past or the present are certain to miss the
>> future [JFK]
>>
>> kandrey89@xxxxxxxxx
>> Live Long and Prosper,
>> Andrey
>>
>
>

PNG image


References