← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Bugfix for component table

 

a bit of a slippery slope for the people who have a schematic with that
field already edited and populated inside the schematic.

Fabrizio


On Tue, May 23, 2017 at 12:18 PM, Oliver Walters <
oliver.henry.walters@xxxxxxxxx> wrote:

> That's a good idea. I'll see if that can be added to the symbol properties
> dialog box.
>
> On 23 May 2017 20:06, "Fabrizio Tappero" <fabrizio.tappero@xxxxxxxxx>
> wrote:
>
>> hum... if the symbol (from the library) has a symbol field I am guessing
>> the same field should appear in the schematic E key menu so that people can
>> edit it. Seen in this way Oliver's implementation is actually very good.
>>
>> cheers
>> Fabrizio
>>
>>
>> On Tue, May 23, 2017 at 10:25 AM, Andrey Kuznetsov <kandrey89@xxxxxxxxx>
>> wrote:
>>
>>> Fabrizio,
>>> Description comes from symbol description I believe, it should be in the
>>> table, even though people aren't likely to use it.
>>> [image: Inline image 1]
>>>
>>> Oliver,
>>> 4. I thought you added the ability to rearrange the column order, I
>>> can't drag and drop the columns around.
>>> 5. The divider between table and fields on the left needs to be saved to
>>> register so that it's size is remembered.
>>> 6. Add an option to right click on the column heading like Value, etc,
>>> and allow to change the align property of the fields, and remember them in
>>> registry by column name.
>>>
>>> Thanks
>>>
>>> On Tue, May 23, 2017 at 1:17 AM, Fabrizio Tappero <
>>> fabrizio.tappero@xxxxxxxxx> wrote:
>>>
>>>> cheers Oliver,
>>>> I do not know what a .dcm file is.
>>>>
>>>> I am not sure it is a good idea to have a in-built field called
>>>> Description in the table viewer. But I can easily see how that is useful. I
>>>> guess you would like to use this table to add info. This makes it non a
>>>> table viewer. The current icon label says "Component table view" which I
>>>> find ambiguous. Maybe Wayne can jump in with a proper name for it.
>>>>
>>>> I am having the feeling the development of this table did not come from
>>>> a clean plan of having an XYZ tool. Or maybe is just me. Please dont get me
>>>> wrong, I love this table (and the soon to come new icon) but it might be a
>>>> good idea to drop the word viewer for it if we want the (great) ability to
>>>> edit stuff.
>>>>
>>>> I hope this helps.
>>>>
>>>> Fabrizio
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On Tue, May 23, 2017 at 10:00 AM, Oliver Walters <
>>>> oliver.henry.walters@xxxxxxxxx> wrote:
>>>>
>>>>> Fabrizio,
>>>>>
>>>>> 1. You have added a custom field called "Description".
>>>>> 2. The table viewer has an "inbuild" field called "Description". It
>>>>> populates this field with the component description which is found in the
>>>>> .dcm files
>>>>>
>>>>> Here's what I see.
>>>>>
>>>>> [image: Inline image 1]
>>>>>
>>>>> Here I have added the custom "description" field with dummy data to
>>>>> only one component.
>>>>>
>>>>> The first "Description" column is filled with the symbol descriptions
>>>>> from the .dcm files in the library.
>>>>>
>>>>> If you are missing the .dcm files then your first column will be empty.
>>>>>
>>>>>
>>>>> On Tue, May 23, 2017 at 5:57 PM, Fabrizio Tappero <
>>>>> fabrizio.tappero@xxxxxxxxx> wrote:
>>>>>
>>>>>> Hi Oliver,
>>>>>> not sure I understand the question. This is what my schematic
>>>>>> components fields look like:
>>>>>>
>>>>>> [image: Inline image 1]
>>>>>>
>>>>>>
>>>>>> cheers
>>>>>> Fabrizio
>>>>>>
>>>>>>
>>>>>> On Tue, May 23, 2017 at 9:53 AM, Andrey Kuznetsov <
>>>>>> kandrey89@xxxxxxxxx> wrote:
>>>>>>
>>>>>>> Previous bug even works without modifying a field, all I have to do
>>>>>>> is enter a field edit mode and click somewhere else, and that field's value
>>>>>>> will be copied to where ever I clicked, this will cause a lot of grief when
>>>>>>> users decide to cancel editing and click elsewhere to discard changes, or
>>>>>>> so they think that's what should have happened.
>>>>>>>
>>>>>>>
>>>>>>> A few more things:
>>>>>>> 1. When I click Apply changes, the RED markings/modified fields
>>>>>>> should disappear when the changes have been successfully applied
>>>>>>> 2. Undo/Redo should work inside Component Table to undo each user
>>>>>>> action, instead of having the user to discard all changes and start over
>>>>>>> 3. There's something weird going on when you try to edit a field, it
>>>>>>> seems that have to click 4 times to enter edit mode, 2 times is what I
>>>>>>> expect. Also perhaps some weird delay that prevents me from entering edit
>>>>>>> mode.
>>>>>>>
>>>>>>> On Tue, May 23, 2017 at 12:39 AM, Andrey Kuznetsov <
>>>>>>> kandrey89@xxxxxxxxx> wrote:
>>>>>>>
>>>>>>>> Oliver, found another unexpected behaviour.
>>>>>>>> When I select a field to edit, for example to replace a "Part
>>>>>>>> Number" field from AAA to BBB, when I type in BBB but instead of hitting
>>>>>>>> enter, I click on the next field below it which belongs to another part,
>>>>>>>> then BBB modifies that part's field instead of where the editing took place.
>>>>>>>>
>>>>>>>> On Tue, May 23, 2017 at 12:28 AM, Oliver Walters <
>>>>>>>> oliver.henry.walters@xxxxxxxxx> wrote:
>>>>>>>>
>>>>>>>>> The "Description" field should be showing the description of each
>>>>>>>>> symbol as it appears in the .dcm file. It was working for me - do your
>>>>>>>>> symbols not have those descriptions?
>>>>>>>>>
>>>>>>>>> On Tue, May 23, 2017 at 5:23 PM, Fabrizio Tappero <
>>>>>>>>> fabrizio.tappero@xxxxxxxxx> wrote:
>>>>>>>>>
>>>>>>>>>> Hi Guys,
>>>>>>>>>> great ! you guys almost fixed it. It looks like the column
>>>>>>>>>> "Description" appears twice and one of the two is completely empty.
>>>>>>>>>>
>>>>>>>>>> cheers
>>>>>>>>>> Fabrizio
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> [image: Inline image 1]
>>>>>>>>>>
>>>>>>>>>> On Mon, May 22, 2017 at 10:18 PM, Wayne Stambaugh <
>>>>>>>>>> stambaughw@xxxxxxxxx> wrote:
>>>>>>>>>>
>>>>>>>>>>> Oliver,
>>>>>>>>>>>
>>>>>>>>>>> I committed your patch.  Thank you.
>>>>>>>>>>>
>>>>>>>>>>> Wayne
>>>>>>>>>>>
>>>>>>>>>>> On 5/22/2017 10:08 AM, Oliver Walters wrote:
>>>>>>>>>>> > Bug noted here - https://lists.launchpad.net/ki
>>>>>>>>>>> cad-developers/msg29485.html
>>>>>>>>>>> >
>>>>>>>>>>> > Patch attached to this email fixes glitch when user adds
>>>>>>>>>>> custom field
>>>>>>>>>>> > with same name as a default field.
>>>>>>>>>>> >
>>>>>>>>>>> > Users can now do this to their heart's content.
>>>>>>>>>>> >
>>>>>>>>>>> >
>>>>>>>>>>> > _______________________________________________
>>>>>>>>>>> > Mailing list: https://launchpad.net/~kicad-developers
>>>>>>>>>>> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>>>>>>> > Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>>>>>>> > More help   : https://help.launchpad.net/ListHelp
>>>>>>>>>>> >
>>>>>>>>>>>
>>>>>>>>>>> _______________________________________________
>>>>>>>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>>>>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> _______________________________________________
>>>>>>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>>>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Remember The Past, Live The Present, Change The Future
>>>>>>>> Those who look only to the past or the present are certain to miss
>>>>>>>> the future [JFK]
>>>>>>>>
>>>>>>>> kandrey89@xxxxxxxxx
>>>>>>>> Live Long and Prosper,
>>>>>>>> Andrey
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Remember The Past, Live The Present, Change The Future
>>>>>>> Those who look only to the past or the present are certain to miss
>>>>>>> the future [JFK]
>>>>>>>
>>>>>>> kandrey89@xxxxxxxxx
>>>>>>> Live Long and Prosper,
>>>>>>> Andrey
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>> Remember The Past, Live The Present, Change The Future
>>> Those who look only to the past or the present are certain to miss the
>>> future [JFK]
>>>
>>> kandrey89@xxxxxxxxx
>>> Live Long and Prosper,
>>> Andrey
>>>
>>
>>

PNG image

PNG image

PNG image

PNG image


References