kicad-developers team mailing list archive

Thread
Date

Re: PATCH: Fix default line widths for non-mm units in DXF import

To: kicad-developers@xxxxxxxxxxxxxxxxxxx
From: "Sergey A. Borshch" <sb-sf@xxxxxxxxxxxxxxxxxxxxx>
Date: Fri, 26 May 2017 11:02:11 +0300
In-reply-to: <CAHBNN+OM9EyDyWeN1eOZo1Bmwu=z0YG1g_BX0RxYCosd+jk8+w@mail.gmail.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1

On 26.05.2017 05:10, Cirilo Bernardo wrote:

Fortunately
there are not many lines that need to be changed and they all
follow the same formula.

Isn't it a good chance to wrap this formula into (inline) function? Nextprogrammer can be not so pedant as you to find all formula occurrences solvingnext bug. This can make sources a little bit more clean.



--
Regards,
  Sergey A. Borshch            mailto: sb-sf@xxxxxxxxxxxxxxx
    SB ELDI ltd. Riga, Latvia

References

PATCH: Fix default line widths for non-mm units in DXF import
From: Cirilo Bernardo, 2017-05-26