kicad-developers team mailing list archive

[Heikki Pulkkinen <hei6mail@xxxxxxxxx>]

Yes of course you have removed them. I just read it wrongly.

On Mon, May 29, 2017 at 10:54 AM, Heikki Pulkkinen <hei6mail@xxxxxxxxx>
wrote:

> This is latest patch. But not files in pcbnew/trackitems directory.
>
> On Mon, May 29, 2017 at 10:46 AM, Heikki Pulkkinen <hei6mail@xxxxxxxxx>
> wrote:
>
>>
>> ---------- Forwarded message ----------
>> From: Heikki Pulkkinen <hei6mail@xxxxxxxxx>
>> Date: Mon, May 29, 2017 at 10:44 AM
>> Subject: Re: [Kicad-developers] teardrops & rounded corners & ???
>> To: Russell Oliver <roliver8143@xxxxxxxxx>
>>
>>
>> Hi
>>
>> It seems that this patch is not going to work, because you have removed
>> preprocessor directive PCBNEW_WITH_TRACKITEMS. If you remove it you have to
>> remove code witch are defined out with this directive.
>>
>> Maybe another way to make patch is clone both branches to their own
>> directory. And then just copy master branch .git directory to my branch
>> directory. And then commit that.
>>
>> Cheers
>>
>> Heikki
>>
>> On Sun, May 28, 2017 at 7:24 PM, Russell Oliver <roliver8143@xxxxxxxxx>
>> wrote:
>>
>>> Hi Heikki and all.
>>>
>>> I'm excited to be able to present a patch of Heikki's work.
>>>
>>> It was created against kicad master branch as of writing. i.e. commit
>>> "3d viewer: cosmetic.." 1fda668f242244af5803dd5a7dd18e1b8cc7ac33
>>> Includes up to "update origin and roundedcorners copy current" from
>>> Heikki's repo.
>>>
>>> It is also available at https://github.com/rustyoz/kicad/tree/teardrops
>>>
>>> Hopefully it makes it a bit easier for everyone to test
>>>
>>> Regards
>>> Russell
>>>
>>> On Sat, May 27, 2017 at 10:30 PM Heikki Pulkkinen <hei6mail@xxxxxxxxx>
>>> wrote:
>>>
>>>> Hi
>>>>
>>>> I think that it was  five or nine day ago some of those 'Fixed
>>>> duplicate field names' or 'Component table is left aligned'..
>>>>
>>>> On Sat, May 27, 2017 at 3:12 PM, Heikki Pulkkinen <hei6mail@xxxxxxxxx>
>>>> wrote:
>>>>
>>>>> I do not know that, but now it is latest and missing files are added
>>>>> too.
>>>>>
>>>>> On Sat, May 27, 2017 at 9:54 AM, Russell Oliver <roliver8143@xxxxxxxxx
>>>>> > wrote:
>>>>>
>>>>>> Hi Heikki,
>>>>>>
>>>>>> Do you know which commit or release that you started developing the
>>>>>> features from? I'll see if i can recreate the necessary git history.
>>>>>>
>>>>>> Regards
>>>>>> Russell
>>>>>>
>>>>>> On Sat, May 27, 2017 at 4:34 PM Heikki Pulkkinen <hei6mail@xxxxxxxxx>
>>>>>> wrote:
>>>>>>
>>>>>>> And that menu structure is what it is. It is there just testing
>>>>>>> purposes. It can be done more intuitive for all users.
>>>>>>>
>>>>>>> Teardrops and these things is going to change kicad_pcb file making
>>>>>>> additions end of file. And that stitch via thermal word is threre too.
>>>>>>>
>>>>>>> 26.5.2017 23.13 "Kaspar Emanuel" <kaspar.emanuel@xxxxxxxxx>
>>>>>>> kirjoitti:
>>>>>>>
>>>>>>>> I managed to compile by copying the missing files over from the
>>>>>>>> main KiCAD repo. Seems to be working fine!
>>>>>>>>
>>>>>>>> Initial feedback:
>>>>>>>>
>>>>>>>>    - Thanks very much for working on this!
>>>>>>>>    - The menu is very unintuitive but is it useful to give
>>>>>>>>    feedback on this? Is it just an intermediate menu for you to continue
>>>>>>>>    development or are you planning for the final functionality to be similar
>>>>>>>>    to what you have there?
>>>>>>>>
>>>>>>>> I will continue to experiment with it in the meantime.
>>>>>>>> ​
>>>>>>>>
>>>>>>>> On 25 May 2017 at 22:59, Nick Østergaard <oe.nick@xxxxxxxxx> wrote:
>>>>>>>>
>>>>>>>>> Basically described in https://help.github.com/articl
>>>>>>>>> es/fork-a-repo/
>>>>>>>>>
>>>>>>>>> (there might exist better tutorials)
>>>>>>>>>
>>>>>>>>> 2017-05-25 21:22 GMT+02:00 Nick Østergaard <oe.nick@xxxxxxxxx>:
>>>>>>>>> >
>>>>>>>>> >
>>>>>>>>> > Den 25/05/2017 19.42 skrev "Kaspar Emanuel" <
>>>>>>>>> kaspar.emanuel@xxxxxxxxx>:
>>>>>>>>> >
>>>>>>>>> > Hey Heikki,
>>>>>>>>> >
>>>>>>>>> > I wanted to give this a test with a small board I thought would
>>>>>>>>> look nicer
>>>>>>>>> > with curved traces.
>>>>>>>>> >
>>>>>>>>> > During the cmake step I noticed following error but was still
>>>>>>>>> able to
>>>>>>>>> > proceed to the make step.
>>>>>>>>> >
>>>>>>>>> > CMake Error at common/CMakeLists.txt:344 (add_library):
>>>>>>>>> >   Cannot find source file:
>>>>>>>>> >
>>>>>>>>> >     build_version.cpp
>>>>>>>>> >
>>>>>>>>> >   Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh
>>>>>>>>> .h++ .hm .hpp
>>>>>>>>> >   .hxx .in .txx
>>>>>>>>> >
>>>>>>>>> > CMake Error at pcbnew/CMakeLists.txt:637 (add_library):
>>>>>>>>> >   Cannot find source file:
>>>>>>>>> >
>>>>>>>>> >     build_BOM_from_board.cpp
>>>>>>>>> >
>>>>>>>>> >   Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh
>>>>>>>>> .h++ .hm .hpp
>>>>>>>>> >   .hxx .in .txx
>>>>>>>>> >
>>>>>>>>> > But the make step exited with a similar error:
>>>>>>>>> >
>>>>>>>>> > /home/kaspar/projects/kicad/heikkipu-kicad-devel/pcbnew/lega
>>>>>>>>> cy_plugin.cpp:89:27:
>>>>>>>>> > fatal error: build_version.h: No such file or directory
>>>>>>>>> > compilation terminated.
>>>>>>>>> > common/CMakeFiles/pcbcommon.dir/build.make:1020: recipe for
>>>>>>>>> target
>>>>>>>>> > 'common/CMakeFiles/pcbcommon.dir/__/pcbnew/legacy_plugin.cpp.o'
>>>>>>>>> failed
>>>>>>>>> > make[2]: *** [common/CMakeFiles/pcbcommon.d
>>>>>>>>> ir/__/pcbnew/legacy_plugin.cpp.o]
>>>>>>>>> > Error 1
>>>>>>>>> > make[2]: *** Waiting for unfinished jobs....
>>>>>>>>> > CMakeFiles/Makefile2:521: recipe for target
>>>>>>>>> > 'common/CMakeFiles/pcbcommon.dir/all' failed
>>>>>>>>> > make[1]: *** [common/CMakeFiles/pcbcommon.dir/all] Error 2
>>>>>>>>> > Makefile:149: recipe for target 'all' failed
>>>>>>>>> > make: *** [all] Error 2
>>>>>>>>> >
>>>>>>>>> > Hope this helps, let me know what to do and I can continue
>>>>>>>>> trying to compile
>>>>>>>>> > it.
>>>>>>>>> >
>>>>>>>>> > Cheers,
>>>>>>>>> >
>>>>>>>>> > Kaspar
>>>>>>>>> >
>>>>>>>>> > P.S. How come your Git repository doesn’t have the same history
>>>>>>>>> as KiCAD git
>>>>>>>>> > repository?
>>>>>>>>> >
>>>>>>>>> > Yeah, that is not the way to send patches. You need to commit in
>>>>>>>>> a local
>>>>>>>>> > branch from the upstream kicad master branch anf push that.
>>>>>>>>> >
>>>>>>>>> >
>>>>>>>>> > On 21 May 2017 at 09:41, Heikki Pulkkinen <hei6mail@xxxxxxxxx>
>>>>>>>>> wrote:
>>>>>>>>> >>
>>>>>>>>> >> Hi Wayne and all
>>>>>>>>> >>
>>>>>>>>> >> Want to test.
>>>>>>>>> >>
>>>>>>>>> >> https://github.com/heikkipu/kicad-devel
>>>>>>>>> >>
>>>>>>>>> >> And yes, it is going to change kicad_pcb file.
>>>>>>>>> >>
>>>>>>>>> >>
>>>>>>>>> >> Regards
>>>>>>>>> >>
>>>>>>>>> >> Heikki
>>>>>>>>> >>
>>>>>>>>> >> _______________________________________________
>>>>>>>>> >> Mailing list: https://launchpad.net/~kicad-developers
>>>>>>>>> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>>>>> >> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>>>>> >> More help   : https://help.launchpad.net/ListHelp
>>>>>>>>> >>
>>>>>>>>> >
>>>>>>>>> >
>>>>>>>>> > _______________________________________________
>>>>>>>>> > Mailing list: https://launchpad.net/~kicad-developers
>>>>>>>>> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>>>>> > Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>>>>> > More help   : https://help.launchpad.net/ListHelp
>>>>>>>>> >
>>>>>>>>> >
>>>>>>>>>
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>>
>>>>>>
>>>>>
>>>>
>>
>>
>