kicad-developers team mailing list archive

[Maciej Sumiński <maciej.suminski@xxxxxxx>]

Hi Russell,

I am sorry for such long delay. I have finally got to review your patch
and I pushed it with another commit containing minor fixes. Thank you
for your contribution to KiCad.

Regards,
Orson

On 06/02/2017 02:50 PM, Russell Oliver wrote:
> Hi All,
> 
> Just wondering if anyone else has tested this patch, or has any comments on
> it?
> 
> Attached is the patch rebased to master as of writing.
> 
> Regards
> Russell
> 
> On Thu, May 11, 2017 at 12:53 AM Russell Oliver <roliver8143@xxxxxxxxx>
> wrote:
> 
>> Hi Tom,
>>
>> Attached is an updated patch which moves the feature into a separate tool
>> class and rebased the latest master commit as of writing.
>>
>> Also available at https://github.com/rustyoz/kicad/tree/position-relative
>>
>> Regards
>> Russell
>>
>> On Fri, May 5, 2017 at 12:18 AM Tomasz Wlostowski <
>> tomasz.wlostowski@xxxxxxx> wrote:
>>
>>> On 30.04.2017 14:47, Russell Oliver wrote:
>>>> Hi Tom,
>>>>
>>>> sorry again,
>>>> Attached is a fixed patch.
>>>
>>> Hi Russell,
>>>
>>> I'd like to merge it. Few more comments:
>>> - check code indentation (you have a mix of tabs and spaces). uncrustify
>>> tool can do that for you.
>>> - the argument naming should follow the aArgument1, aArg2, etc. convention
>>> - the tool is relatively complex. consider creating a new tool class for
>>> it, the EDIT_TOOL class is already quite big.
>>>
>>> Best,
>>> Tom
>>>
>>
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Attachment: signature.asc
Description: OpenPGP digital signature