kicad-developers team mailing list archive

[Maciej Sumiński <maciej.suminski@xxxxxxx>]

Hi Oliver,

I have not checked the details, but I assume it is caused by multiple
notifications sent by every (un)select operation
(m_toolMgr->ProcessEvent( SelectedEvent )). Surely worth further
inspection, I would not expect it to be that slow.

Cheers,
Orson

On 06/13/2017 01:22 AM, Oliver Walters wrote:
> Thanks Maciej,
> 
> Any guess as to why the SELECT / UNSELECT of multiple objects takes a very
> long time? I was unable to solve this problem.
> 
> Cheers,
> 
> Oliver
> 
> On Mon, Jun 12, 2017 at 7:29 PM, Maciej Sumiński <maciej.suminski@xxxxxxx>
> wrote:
> 
>> Hi Oliver,
>>
>> I apologize for late answer, I was away from keyboard for the last 3
>> weeks and now I am crawling through my mailbox.
>>
>> Well done, your changes resolve the issue correctly, so thank you for
>> investigating the problem. I have just committed the patch with some
>> minor changes (removed doxygen-style comments for functions from .cpp
>> files, they are supposed to be located in headers [1]).
>>
>> Regards,
>> Orson
>>
>> 1.
>> http://kicad-source-mirror.readthedocs.io/en/latest/
>> Documentation/development/coding-style-policy/#321-
>> function-comments-function_comments
>>
>> On 05/28/2017 02:40 PM, Oliver Walters wrote:
>>> Improved speed of Duplicate action
>>>
>>> - Removed repetitive tool calls
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>

Attachment: signature.asc
Description: OpenPGP digital signature