← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] hierarchy navigator icon moved where it belongs

 

Hi guys,
no worries. To my eyes this change was similar to move the zoom icon. I
learn only now that right hand side icons change the status of the mouse
and horizontal icons cannot have this functionality. My knowledge of KiCad
is definitely limited.


+1 for removing it. I find its use already fulfilled by the hierarchical
nav dialog.

cheers
Fabrizio



On Sat, Jun 17, 2017 at 2:41 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx>
wrote:

> On 6/17/2017 8:11 AM, jp charras wrote:
> > Le 17/06/2017 à 13:38, Fabrizio Tappero a écrit :
> >> Hi guys,
> >> I'd like to reminder that this patch is still pending. I would love it
> to be applied.
> >>
> >> cheers
> >> Fabrizio
> >
> > Hi Fabrizio,
> >
> > Sorry to say that, but you cannot move this icon without changing the
> associated code.
> > Unlike icons in vertical toolbar, this icon, like all icons of the
> vertical right toolbar, is a
> > wxITEM_CHECK tool (and unlike tools of the main upper toolbar).
> >
> > To tell the truth, I am not especially thrilled by your proposal,
> because this icon does not act as
> > the hierarchy navigator icon in main toolbar, but like any other tool
> icon of the vertical right
> > toolbar (It changes the properties of the left click mouse button and
> the shape of the mouse cursor).
> >
> > For instance, after moving the Zoom on selection tool from vertical
> toolbar to main toolbar, I spent
> > 2 days to fix UI issues created by this change.
> > Just because the associated code was designed to manage tools of the
> vertical toolbar, not for any
> > tool in any toolbar, both in legacy canvas and gal canvas, and was not
> fixed by the initial patch.
> >
>
> I'm going to side with JP on this.  While I applaud all efforts to
> improve our UI consistency, breaking things is not the way to go about it.
>
> I wonder if the navigation tool is really necessary.  Does any one use
> it?  I can't recall ever using it.  We already have the hierarchy
> navigator dialog, leave sheet command, double click to enter a sheet,
> and alt-bkspc to leave sheet.  Interestingly, the hierarchy navigation
> tool always enabled even on schematics with no sheets.  Perhaps this is
> a tool that we can remove in the name of simplification.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

References