← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] correct text inside two importantplot windows

 

Hi,

Random comments for a few of the topics discussed or proposed:

- "Format" -> "Coordinate Format": The Gerber standard
<https://www.ucamco.com/files/downloads/file/81/the_gerber_file_format_specification.pdf>
uses
Coordinate format for this, so I think this change is OK.

- "solder mask" vs "solder stop mask": I'm European and I've never used (or
heard used) "solder stop mask". Always solder mask or I've also used resist
or solder resist. But I think solder mask is the most common.

- "Save Messages to File": +1

- "Default line width" -> "Line width": please don't. The former is more
descriptive and correct in my opinion.

Thanks,

Diego

On Wed, Jun 21, 2017 at 5:59 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx>
wrote:

> Fabrizio,
>
> I finally had a chance to look at this.  Here are my comments.
>
> You fixed the capitalization for some labels but broke it for others.
> Please take a look at the "Capitalization Table" section in the KiCad
> "User Interface Guidelines" [1] and make the appropriate changes.
>
> For the most part we do not use colons (:) at the end of group box
> label.  I know we are not as consistent with this as we should be but
> most of the dialogs do not use them.  We should probably make this a UI
> policy.  Text labels for other controls should have a colon at the end.
>
> I don't think the wording change from "Current solder mask settings" to
> "Solder Stop Mask Options" is very good.  Here in the states, I cannot
> ever remember some referring to solder mask as solder stop mask.  Maybe
> this is a European thing.
>
> The "Save Output" button could be more descriptive.  The previous label
> was better (although capitalized incorrectly).  Perhaps "Save Messages
> to File" would be better.
>
> Everything else seems fine to me.
>
> Cheers,
>
> Wayne
>
>
> [1]:
> http://docs.kicad-pcb.org/doxygen/md_Documentation_
> development_ui-policy.html
>
> On 6/9/2017 6:43 AM, Fabrizio Tappero wrote:
> > things like
> >
> > Options => Options:
> > 4.5 (unit mm) => 4.5, unit mm
> > Messages => Output Mesages:
> > Save report to file... => Save Output
> > Capital letters, shorten sentences, etc
> >
> > Please refer to the patch for a detailed
> >
> > cheers
> > Fabrizio
> >
> >
> > On Fri, Jun 9, 2017 at 12:31 AM, liyoubdu <liyoubdu@xxxxxx
> > <mailto:liyoubdu@xxxxxx>> wrote:
> >
> >
> >     It is not obvious what you changed here
> >     ---Original---
> >     *From:* "Nick Østergaard"<oe.nick@xxxxxxxxx <mailto:
> oe.nick@xxxxxxxxx>>
> >     *Date:* 2017/6/9 00:39:01
> >     *To:* "Fabrizio Tappero"<fabrizio.tappero@xxxxxxxxx
> >     <mailto:fabrizio.tappero@xxxxxxxxx>>;
> >     *Cc:* "KiCad Developers"<kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>;
> >     *Subject:* Re: [Kicad-developers] [PATCH] correct text inside two
> >     importantplot windows
> >
> >     It is not obvious what you changed here. Could you explain in detail?
> >
> >     2017-06-08 13:00 GMT+02:00 Fabrizio Tappero
> >     <fabrizio.tappero@xxxxxxxxx <mailto:fabrizio.tappero@xxxxxxxxx>>:
> >
> >         Hello,
> >         the following patch corrects some text
> >         ​ and labels​
> >         inside the two Plot menus accessible from schematic editor and
> >         pcb editor. See below
> >
> >         ​​
> >         ​​
> >
> >
> >
> >         So that we know what we are talking about I include here a
> >         before vs after comparison
> >
> >
> >
> >
> >
> >
> >
> >         ​Cheers
> >         Fabrizio
> >
> >         _______________________________________________
> >         Mailing list: https://launchpad.net/~kicad-developers
> >         <https://launchpad.net/%7Ekicad-developers>
> >         Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >         Unsubscribe : https://launchpad.net/~kicad-developers
> >         <https://launchpad.net/%7Ekicad-developers>
> >         More help   : https://help.launchpad.net/ListHelp
> >         <https://help.launchpad.net/ListHelp>
> >
> >
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Follow ups

References