← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Refactor COMMON_ACTIONS into a base and derived class

 

Hi Jon,

It looks like this patch did a lot of good stuff. Nice work!

I don't use kicad often, but when I do, it's with a carefully optimized keyboard mapping and enough stimulants that I look like a professional starcraft player with the fingers flying and the crowd cheering. Really something to behold.

The hardcoded keys in this patch are preventing my keyboard mapping from working. I'm reading unfamiliar code, but examples include 'I' and 'U' keys being masked, and the Lock/Unlock action being forced to 'L'.

I'm slowly wading my way through the code, finding which of your keys are masking mine, and recompiling; so I should be up and running eventually.

Is there a plan to finish linking in hotkey support (remove the hardcoding) for this stuff? Anything I can do to encourage?


Best,

hauptmech





On 17/02/17 16:56, Jon Evans wrote:
Hi all,

More preparation for GerbView GAL port: this patch pulls a virtual ACTIONS class out of pcbnew and renames the COMMON_ACTIONS to PCB_ACTIONS for clarity.

Best,
Jon


_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp



Follow ups

References