← Back to team overview

kicad-developers team mailing list archive

Re: Hard-coded hotkeys in pcbnew/tools/selection_tool.cpp

 

In my opinion - yes. This is the simplest way to make them editable, and
for now I do not think we need to invent a completely new approach, at
least until we kick out the legacy canvas.

Regards,
Orson

On 06/29/2017 03:18 AM, Jon Evans wrote:
> In fact, this isn't the only GAL hotkey that is hard-coded right now.
> I noticed that the GAL tools that have editable hotkeys use the
> TOOL_ACTION::LegacyHotkey -- what should be done about GAL-only features
> that had hotkeys added?  Should they be shown in the hotkey editing window
> with a note that they are OpenGL/Cairo only?
> 
> -Jon
> 
> On Tue, Jun 27, 2017 at 10:11 AM, Nick Østergaard <oe.nick@xxxxxxxxx> wrote:
> 
>> If no one picks up the task now, I think a bug should be reported for
>> tracking.
>>
>> Den 27. jun. 2017 2.50 PM skrev "Maciej Sumiński" <maciej.suminski@xxxxxxx
>>> :
>>
>>> Hi hauptmech,
>>>
>>> I agree this has to be fixed, yet I doubt it is located on someone's
>>> list. If noone steps in, then most likely I will do it at one point in
>>> the future.
>>>
>>> Regards,
>>> Orson
>>>
>>> On 06/27/2017 01:29 PM, hauptmech wrote:
>>>> @Jon Evans maybe,
>>>>
>>>> I spent an embarrasing amount of time trying to assign hotkey actions to
>>>> the 'I' and 'U' keys in pcbnew before realizing they were getting
>>>> captured somewhere else and digging into the source. It appears that
>>>> they have been hard-coded in pcbnew/tools/selection_tool.cpp for
>>>> selectConnection and selectCopper.
>>>>
>>>> If this is the case, does someone have it on their todo list to fix?
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
> 


References