← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] renamed eeschema right click menu "copy" into "duplicate" and some more

 

Hi Guys,
I agree with making the CTRL+D the key for duplicated in eeschema so
that it is coherent with the same duplicated key in pcbnew. I did not
insist with Wayne on this because I felt he knew why it was a good
idea not to do it.

But if I can insist I insist ;-)

Cheers
Fabrizio




On Mon, Jul 3, 2017 at 6:10 PM, Maciej Sumiński <maciej.suminski@xxxxxxx> wrote:
> For the record, the patch is merged. I kept the old hot key for
> duplication (as requested), but if I were to decide - I would go for
> CTRL+D. Alternatively, I would change pcbnew to use C for duplicate,
> just make the hot keys coherent.
>
> Cheers,
> Orson
>
> On 06/23/2017 08:00 PM, Wayne Stambaugh wrote:
>> Fabrizio,
>>
>> I took a look at this patch and have a few comments.
>>
>> It will need to be rebased since I've already removed the hierarchy tool
>> and all related code.
>>
>> The ctrl-d hotkey is already used in pcbnew so I don't think changing it
>> in eeschema makes sense.  I would keep 'C' in eeschema for consistency.
>>
>> I'm OK with the icon changes and the terminology change form "Copy" to
>> "Duplicate".
>>
>> Thanks,
>>
>> Wayne
>>
>> On 6/20/2017 6:02 AM, Fabrizio Tappero wrote:
>>> Hello,
>>> following up on the recent proposal to rename the eeschema "copy"
>>> command into "duplicate" and its shortcut I am sending this patch.
>>>
>>> Specifically this patch does the following:
>>>
>>> 1) rename eeschema right click menu item "Copy" into "Duplicate"
>>> 2) rename eeschema right click menu item "Save block" into "Copy block"
>>> 3) change "Duplicate" shortcut from "C" to "Ctrl-D"
>>> 4) change eeschema right click menu item "Duplicate" icon from a copy
>>> icon into a duplicate
>>> 5) deletes right vertical toolbar "ascend/descend hierarchy" icon and
>>> its unnecessary code. Please make sure I deleted all of it.
>>> 6) replace few redundant icons in the eeschema right click menu into
>>> more global icon (now global move icon)
>>> 7) replace the "mirror_footprint_axisX.svg" for a more standard
>>> "mirror" global icon.
>>> 8) replaced eeschema right click menu "delete_text" icon with more
>>> global "delete" icon
>>>
>>>
>>> Cheers
>>> Fabrizio
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>


Follow ups

References