← Back to team overview

kicad-developers team mailing list archive

Re: Improving SCM behaviour of kicad_pcb

 

Joakim,

I was not aware that there were two different code paths for annotating
power symbols.  I'm not sure why that is but your solution seems sound.
Would you please make your source tree available or provide a patch of
the changes so we can review it to see if makes sense to merge the
changes into the master branch.  I'm sure a lot of users would like to
see this change make it into KiCad.

Cheers,

Wayne

On 7/12/2017 5:43 PM, Joakim Asplund wrote:
> I found previously that there are two different pieces of code that
> annotates the power symbols. One is the normal annotation code. The
> other uses a completely different numbering scheme and runs silently
> before DRC and netlist generation and renumbers all power symbols on all
> open sheets. This caused lots of problems for us because even sheets we
> hadn't touched changed and we were working on different sheets in
> parallel using Git.
> 
> Our workaround for a while was to run the normal annotation command
> after generating the netlist, but now I instead use a modified branch of
> Kicad where I have ripped out the alternative power symbols annotation
> code (AnnotatePowerSymbols). I also removed the code which cleans out
> all the power symbol references before the normal annotate
> (ResetHiddenReferences). I couldn't see why it was needed because the
> annotation code already knows how to assign only new references and
> leave already-assigned references as they were.
> 
> Regards
> Joakim
> 
> On Tue, Jul 11, 2017 at 8:14 AM, jp charras <jp.charras@xxxxxxxxxx
> <mailto:jp.charras@xxxxxxxxxx>> wrote:
> 
>     Le 10/07/2017 à 20:51, Wayne Stambaugh a écrit :
>     > I'm not sure why power symbols would be re-annotated.  Maybe JP could
>     > shed some light on this.  It does seem odd that power symbols are
>     > annotated differently than non-power symbols.
> 
>     There are 2 reasons:
>     * silently annotating power symbols (that are frequently modified)
>     avoids too frequently popup the
>     annotate dialog (the early versions of Eeschema did not annotate
>     silently power symbols, and this
>     annotate dialog, only to annotate power symbols, was annoying and
>     even strange).
>     * reset the reference (not meaningful for users) of power symbols
>     and rebuild it is just the easier
>     way to update these reference, from the point of view of C++ code.
>     Of course, this is not optimal from the point of view of SCM, but
>     when this code was written, SCM
>     was not used to manage schematic project files.
> 
>     >
>     > On 7/10/2017 2:06 PM, José Ignacio wrote:
>     >> I've noticed another annoying churn in eeschema, when annotating the
>     >> schematics power flags get re-annotated even if they already had refs
>     >> assigned from before and the annotate command is not set to overwrite. I
>     >> don't know if it does it all the time but it does it fairly often in my
>     >> experience.
>     >>
> 
> 
> 
>     --
>     Jean-Pierre CHARRAS
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     <https://launchpad.net/~kicad-developers>
>     More help   : https://help.launchpad.net/ListHelp
>     <https://help.launchpad.net/ListHelp>
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


References