← Back to team overview

kicad-developers team mailing list archive

Re: LOCALE_IO sucks

 

Hi Chris,

If your main goal is to reduce the time required to load the libraries
(awesome!) then keep in mind the I/O benchmarks [1] executed by John
Beard some time ago.

Cheers,
Orson

1. https://lists.launchpad.net/kicad-developers/msg27899.html

On 07/18/2017 03:47 PM, Chris Pavlina wrote:
> Yes, the goal would be to try to make the footprint parser entirely
> non-locale-sensitive so as not to need to switch anyway. The problem with
> LOCALE_IO is that it's incompatible with threading (especially on Windows
> where msys2 provides no concept of a thread-local locale), so there's no
> way to background parsing. I really need to eliminate a GUI freeze on
> parse, people are not happy with it.
> 
> As for removing it entirely from other places too, this may be less
> feasible. For now I just want it out of the footprint parser. Removing it
> in other places too may have to wait.
> 
> On Jul 18, 2017 7:12 AM, "Wayne Stambaugh" <stambaughw@xxxxxxxxx> wrote:
> 
>> I have no objections as long as nothing gets broken and the code doesn't
>> get more complicated (less readable).  LOCALE_IO exists in all of the
>> plugins not just the kicad plugin so there is a lot of code to fix.  The
>> reason LOCALE_IO exists is to hide resetting the locale on exceptions.
>> I don't see how any other solution is going to result in cleaner code
>> but I'm willing to entertain the idea.  Please test your changes
>> thoroughly and submit a patch so we can test it and take a look at it
>> before committing.
>>
>> On 7/17/2017 8:44 PM, Chris Pavlina wrote:
>>> If I somehow found the time to strip LOCALE_IO completely out of the
>>> footprint parser without changing the behavior, would anyone have any
>>> religious objections or otherwise mourn the loss?
>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Attachment: signature.asc
Description: OpenPGP digital signature


References