← Back to team overview

kicad-developers team mailing list archive

Re: [patch] move exactly tool refactoring

 

Hi Robert,

I have just committed your patch with some minor changes on top. Thank
you for your contribution to KiCad.

Regards,
Orson

On 06/22/2017 10:22 PM, Robbert Lagerweij wrote:
> Hi all,
> 
> 
> While writing the documentation for the new origin selection feature in the move exactly tool, I found some ways to improve the consistency of its behaviour. I then could not help but also improve the structure of the code a bit while I was at it.
> 
> 
> These two patches together do the following:
> 
> * move the determination of the origin coordinates to the dialog (reduces code duplication across tools somewhat)
> * extract a method to determine the anchor point of the move to reduce the size of the move exact method
> * improve the logic of the anchor point determination for selections of multiple objects which do not contain footprints
> 
> Happy to receive any and all comments and suggestions for improvements.
> 
> Kind regards,
> 
> Robbert
> 
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Attachment: signature.asc
Description: OpenPGP digital signature


References