kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #30149
Re: Speed improvements for SELECT / DESELECT in GAL
-
To:
<kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
From:
Maciej Sumiński <maciej.suminski@xxxxxxx>
-
Date:
Tue, 25 Jul 2017 17:18:22 +0200
-
Authentication-results:
spf=pass (sender IP is 188.184.36.48) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
In-reply-to:
<CAMfgvU9S0CMAJv_7OKjEt-bOb01Y_jP9USSUu=b27qi=8Xc6-A@mail.gmail.com>
-
Spamdiagnosticmetadata:
NSPM
-
Spamdiagnosticoutput:
1:99
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1
Hi Oliver,
Thank you very much, I have just pushed your patch.
Cheers,
Orson
On 07/24/2017 04:25 PM, Oliver Walters wrote:
> When I was working on speed improvements for DUPLICATE action in GAL, I
> also discovered that the select / deselect functions were very slow.
>
> Ref: https://lists.launchpad.net/kicad-developers/msg29539.html
>
> The attached patch reduces time taken to select / deselect items by ~75%
>
> Test Case: ~500 SSOP footprints, select all / deselect all
>
> Essentially, selecting and deselecting forced an invalidation of the item
> layer set, which quickly adds up in terms of time taken to regenerate layer
> data.
>
> Now only KIGFX::COLOR is invalidated.
>
> Cheers,
> Oliver
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Attachment:
signature.asc
Description: OpenPGP digital signature
References
