← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH 1/2] Update FindGLEW.cmake

 


On 7/27/2017 7:29 AM, Simon Richter wrote:
> Hi,
> 
> On 27.07.2017 11:38, Maciej Sumiński wrote:
> 
>> Are there any problems with the current FindGLEW script? I rather would
>> not modify correct CMake scripts without any particular reason, as it
>> may result in new problems.
> 
> Yes, it doesn't support the mapping of debug and release builds on
> Windows (debug builds have an extra "d" in the file name, and a slightly
> different ABI, so the selected version needs to match whether the
> program is being built in debug mode).
> 
> The "new" script is the one from CMake upstream.
> 
>    Simon

Did you just copy this from CMake or did you merge it with our changes
to the old FindGLEW.cmake?  If you copied it, it will most likely break
msys2 builds on windows.  Did you test it on msys2?


Follow ups

References