kicad-developers team mailing list archive

[jp charras <jp.charras@xxxxxxxxxx>]

Le 04/08/2017 à 20:07, Wayne Stambaugh a écrit :
> On 8/4/2017 12:31 PM, Tomasz Wlostowski wrote:
>> On 04.08.2017 18:22, jp charras wrote:
>>> Hi Tomasz,
>>>
>>> I have this annoying warning when compiling Kicad on msys2:
>>>
>>> F:/kicad-launchpad/git_testing/pcbnew/ratsnest_data.cpp: In member function 'const
>>> std::__cxx11::list<std::shared_ptr<hed::EDGE> >&
>>> RN_NET::TRIANGULATOR_STATE::hedTriangulation(std::vector<std::shared_ptr<hed::NODE> >&)':
>>> F:/kicad-launchpad/git_testing/pcbnew/ratsnest_data.cpp:171:34: warning: reference to local variable
>>> 'edges' returned [-Wreturn-local-addr]
>>>          std::list<hed::EDGE_PTR> edges;
>>>
>>>
>>> Could you have a look into it?
>>>
>> Hi,
>>
>> I overlooked this, but fortunately this code is not used. I'll fix it asap.
> 
> I'm also getting a bunch of of the following warnings:
> 
> include/class_colors_design_settings.h:58:18: warning: 'virtual void
> COLORS_DESIGN_SETTINGS::Load(wxConfigBase*)' can be marked override
> [-Wsuggest-override]
>      virtual void Load( wxConfigBase *aConfig );
>                   ^~~~
> include/class_colors_design_settings.h:59:18: warning: 'virtual void
> COLORS_DESIGN_SETTINGS::Save(wxConfigBase*)' can be marked override
> [-Wsuggest-override]
>      virtual void Save( wxConfigBase *aConfig );

Hi Wayne,

I fixed (and committed the fix) for missing override keyword.



-- 
Jean-Pierre CHARRAS