← Back to team overview

kicad-developers team mailing list archive

Re: Python script offered as example for Action Plugin and wxFormBuilder integration

 

I'm OK with pep8 or some variation there of.

On 8/12/2017 12:42 PM, Adam Wolf wrote:
> Sure.  I was actually in the audience for that talk :)  IIRC, the
> biggest takeaway is that sometimes there are exceptions, especially
> for highly idiomatic code, and also that the 80 character original
> line length limit is silly today and something like 120 is more
> appropriate.

Our C++ coding policy is 100 characters so for the sake of consistency
we should probably do the same for Python source files.

> 
> If you have particular changes you'd like to suggest to PEP8 for
> Python style, let's discuss them.  On the other hand, we have no
> automatic code rejection because of style--it's all human enforced at
> this point, which means those exceptions for highly idiomatic code,
> when commented and explained to the committer, already get through.
> 
> Adam Wolf
> 
> On Sat, Aug 12, 2017 at 11:30 AM, Kevin Cozens <kevin@xxxxxxxxx> wrote:
>> On 2017-08-12 11:43 AM, Adam Wolf wrote:
>>>
>>> I think PEP8 is great for us.  Let's just add a line that says "We use
>>> PEP8 as our Python style guide."
>>
>>
>> Before you get too deep in to following PEP8 you might want to watch the
>> video of a talk given by Raymond Hettinger (a core Python programmer) at
>> PyCon 2015. The talk is called Beyond "PEP 8 -- Best practices for beautiful
>> intelligible code" and can be seen at:
>>     https://www.youtube.com/watch?v=wf-BqAjZb8M
>>
>> --
>> Cheers!
>>
>> Kevin.
>>
>> http://www.ve3syb.ca/           |"Nerds make the shiny things that distract
>> Owner of Elecraft K2 #2172      | the mouth-breathers, and that's why we're
>>                                 | powerful!"
>> #include <disclaimer/favourite> |             --Chris Hardwick
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 



References