← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Change track width setting to dropbox

 

Hi Matthias,

Your patch looks good to me. I would love to see the same change done
for via hole and diameter text controls.

Regarding inch vs mil, IMHO mils are better suited for PCB design.
Still, I would rather keep pcbnew consistent, so I suppose we should
stay with inches for the time being.

Regards,
Orson

On 08/24/2017 09:16 PM, Mathias Grimmberger wrote:
> 
> Hi all,
> 
> Mathias Grimmberger <mgri@xxxxxxxxxxxxx> writes:
>>
>> Hi Wayne,
>>
>> Wayne Stambaugh <stambaughw@xxxxxxxxx> writes:
>>
>>> Rather than add a wxComboBox to the WX_UNIT_BINDER object, wouldn't be
>>> be cleaner to change wxTextCtrl* to wxTextEntry* which wxComboBox and
>>> wxTextCtrl (along with several others) are derived from?
>>
>> Yes, of course, I will change that.
> 
> Here is the version of the patch with a nicer modification to
> WX_UNIT_BINDER.
> 
> BTW, I noticed that displaying e.g. track width in inches feels somehow
> strange, would people like having selected values displayed in mils?
> 
> 
> Have fun,
> 
> MGri
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Attachment: signature.asc
Description: OpenPGP digital signature


Follow ups

References